Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1868103002: Remove several domains from the HSTS preload list and remove an extra space. (Closed)

Created:
4 years, 8 months ago by lgarron
Modified:
4 years, 8 months ago
Reviewers:
palmer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Remove several domains from the HSTS preload list and remove an extra space. videomail.io: > I mistakenly used this code for helmet, a npm package to set various > HTTP headers: > > ``` > app.use(helmet.hsts({ > maxAge: 108864000000, // Must be at least 18 weeks to be approved by Google > preload: true > })) > ``` > > But now, I can't visit the local site with plain HTTP anymore. I need > that for some tests. tablotv.com: > No one from our organization (we are small) added our domain to the list and > according to the documentation on the HSTS preload site it may take many > revisions to be removed from the list. > ... > As for how it happened, we are not sure. involved-it.be: > Several months ago I (accidently) added involved-it.be to the HSTS > preload list presumably via https://hstspreload.appspot.com/. bam.com.au: A mail subdomain hosted by a third-party does not support SSL. logotype.se: > The reason is that I do development, and for some subdomains I don't > have TLS setup on the different server instances. BUG=527947 TBR=palmer@chromium.org Review URL: https://codereview.chromium.org/1814053002 Cr-Commit-Position: refs/heads/master@{#385850} (cherry picked from commit 253102d2f4b59a803816d2567233a5823ab5d782) Committed: https://chromium.googlesource.com/chromium/src/+/0e1ae5860dfc8a16b00545b8be3c89f1c77260e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6348 lines, -6356 lines) Patch
M net/http/transport_security_state_static.h View 1 chunk +6347 lines, -6351 lines 0 comments Download
M net/http/transport_security_state_static.json View 5 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
lgarron
4 years, 8 months ago (2016-04-08 00:43:20 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0e1ae5860dfc8a16b00545b8be3c89f1c77260e0 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698