Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1814053002: Remove several domains from the HSTS preload list and remove an extra space. (Closed)

Created:
4 years, 9 months ago by lgarron
Modified:
4 years, 8 months ago
Reviewers:
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove several domains from the HSTS preload list and remove an extra space. videomail.io: > I mistakenly used this code for helmet, a npm package to set various > HTTP headers: > > ``` > app.use(helmet.hsts({ > maxAge: 108864000000, // Must be at least 18 weeks to be approved by Google > preload: true > })) > ``` > > But now, I can't visit the local site with plain HTTP anymore. I need > that for some tests. tablotv.com: > No one from our organization (we are small) added our domain to the list and > according to the documentation on the HSTS preload site it may take many > revisions to be removed from the list. > ... > As for how it happened, we are not sure. involved-it.be: > Several months ago I (accidently) added involved-it.be to the HSTS > preload list presumably via https://hstspreload.appspot.com/. bam.com.au: A mail subdomain hosted by a third-party does not support SSL. logotype.se: > The reason is that I do development, and for some subdomains I don't > have TLS setup on the different server instances. BUG=527947 TBR=palmer@chromium.org Committed: https://crrev.com/253102d2f4b59a803816d2567233a5823ab5d782 Cr-Commit-Position: refs/heads/master@{#385850}

Patch Set 1 #

Patch Set 2 : Updates #

Patch Set 3 : Update .h file. #

Patch Set 4 : Add the .h changes forrealz (gotta hack depot_tools for this...) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6348 lines, -6356 lines) Patch
M net/http/transport_security_state_static.h View 1 2 3 1 chunk +6347 lines, -6351 lines 0 comments Download
M net/http/transport_security_state_static.json View 1 3 5 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
lgarron
Note: since https://crbug.com/595493 is still open and requests are likely to continue in the coming ...
4 years, 9 months ago (2016-03-17 21:43:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1814053002/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1814053002/50001
4 years, 8 months ago (2016-04-07 19:55:46 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:50001)
4 years, 8 months ago (2016-04-07 21:12:13 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 21:29:23 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/253102d2f4b59a803816d2567233a5823ab5d782
Cr-Commit-Position: refs/heads/master@{#385850}

Powered by Google App Engine
This is Rietveld 408576698