Preserving first/middle/last names when an Autofill profile is submitted

chrome/browser/ui/webui/options/autofill_options_handler.h

Index: chrome/browser/ui/webui/options/autofill_options_handler.h
diff --git a/chrome/browser/ui/webui/options/autofill_options_handler.h b/chrome/browser/ui/webui/options/autofill_options_handler.h
index ef00b3ec45bf4d79634e491ea5179453358b8c32..f38e547fc3969bbd57d6505ca6ff8c826d49ff2b 100644
--- a/chrome/browser/ui/webui/options/autofill_options_handler.h
+++ b/chrome/browser/ui/webui/options/autofill_options_handler.h
@@ -43,6 +43,8 @@ class AutofillOptionsHandler : public OptionsPageUIHandler,
 
  private:
   FRIEND_TEST_ALL_PREFIXES(AutofillOptionsHandlerTest, AddressToDictionary);
+  FRIEND_TEST_ALL_PREFIXES(AutofillOptionsHandlerTest,
+                           ShouldTransferNameComponents);
 
   // Loads the strings for the address and credit card overlays.
   void SetAddressOverlayStrings(base::DictionaryValue* localized_strings);
@@ -102,10 +104,21 @@ class AutofillOptionsHandler : public OptionsPageUIHandler,
       const autofill::AutofillProfile& profile,
       base::DictionaryValue* address);
 
+  // Returns true iff the full name entered in |profile| is a concatenation of
+  // some combination of the first/middle/last (incl. middle initial) in
+  // |prior_profile|.

[tmartino, 2016/04/08 17:16:16]

Does this run into i18n issues? If so, is there a library I should defer to?

+  static bool ShouldTransferNameComponents(
+      const autofill::AutofillProfile& profile,
+      const autofill::AutofillProfile& prior_profile);
+
   // The personal data manager, used to load Autofill profiles and credit cards.
   // Unowned pointer, may not be NULL.
   autofill::PersonalDataManager* personal_data_;
 
+  // The profile which was last used to populate the Address Editor. Unowned;
+  // not populated until LoadAdressEditor is called.
+  autofill::AutofillProfile* prior_profile_;

[Mathieu, 2016/04/11 15:01:21]

initialize it to nullptr in the constructor

[tmartino, 2016/04/12 20:48:27]

Done. Also changed personal_data_ to use nullptr on the same line, for
consistency.

+
   DISALLOW_COPY_AND_ASSIGN(AutofillOptionsHandler);
 };