Preserving first/middle/last names when an Autofill profile is submitted

chrome/browser/ui/webui/options/autofill_options_handler.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_OPTIONS_AUTOFILL_OPTIONS_HANDLER_H_
 #define CHROME_BROWSER_UI_WEBUI_OPTIONS_AUTOFILL_OPTIONS_HANDLER_H_
 
 #include <string>
 
 #include "base/compiler_specific.h"
@@ skipping 25 matching lines @@
   void GetLocalizedValues(base::DictionaryValue* localized_strings) override;
   void InitializeHandler() override;
   void InitializePage() override;
   void RegisterMessages() override;
 
   // PersonalDataManagerObserver implementation.
   void OnPersonalDataChanged() override;
 
  private:
   FRIEND_TEST_ALL_PREFIXES(AutofillOptionsHandlerTest, AddressToDictionary);
+  FRIEND_TEST_ALL_PREFIXES(AutofillOptionsHandlerTest,
+                           ShouldTransferNameComponents);
 
   // Loads the strings for the address and credit card overlays.
   void SetAddressOverlayStrings(base::DictionaryValue* localized_strings);
   void SetCreditCardOverlayStrings(base::DictionaryValue* localized_strings);
 
   // Loads Autofill addresses and credit cards using the PersonalDataManager.
   void LoadAutofillData();
 
   // Removes data from the PersonalDataManager.
   // |args| - A string, the GUID of the address or credit card to remove.
@@ skipping 39 matching lines @@
   void RemaskServerCard(const base::ListValue* args);
 
   // Returns true if |personal_data_| is non-null and loaded.
   bool IsPersonalDataLoaded() const;
 
   // Fills in |address| with the data format that the options js expects.
   static void AutofillProfileToDictionary(
       const autofill::AutofillProfile& profile,
       base::DictionaryValue* address);
 
+  // Returns true iff the full name entered in |profile| is a concatenation of
+  // some combination of the first/middle/last (incl. middle initial) in
+  // |prior_profile|.

[tmartino, 2016/04/08 17:16:16]

Does this run into i18n issues? If so, is there a library I should defer to?

+  static bool ShouldTransferNameComponents(
+      const autofill::AutofillProfile& profile,
+      const autofill::AutofillProfile& prior_profile);
+
   // The personal data manager, used to load Autofill profiles and credit cards.
   // Unowned pointer, may not be NULL.
   autofill::PersonalDataManager* personal_data_;
 
+  // The profile which was last used to populate the Address Editor. Unowned;
+  // not populated until LoadAdressEditor is called.
+  autofill::AutofillProfile* prior_profile_;

[Mathieu, 2016/04/11 15:01:21]

initialize it to nullptr in the constructor

[tmartino, 2016/04/12 20:48:27]

Done. Also changed personal_data_ to use nullptr on the same line, for
consistency.

+
   DISALLOW_COPY_AND_ASSIGN(AutofillOptionsHandler);
 };
 
 }  // namespace options
 
 #endif  // CHROME_BROWSER_UI_WEBUI_OPTIONS_AUTOFILL_OPTIONS_HANDLER_H_