Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 1867903002: [DevTools] Fix crash when runtime.evaluate is called with contextId = 0 (Closed)

Created:
4 years, 8 months ago by kozy
Modified:
4 years, 8 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kinuko+watch, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fix crash when runtime.evaluate is called with contextId = 0 BUG=599947 R=dgozman@chromium.org Committed: https://crrev.com/d3e1f6b795170d0cb6a160f5193ddd2b89c812b5 Cr-Commit-Position: refs/heads/master@{#385839}

Patch Set 1 : #

Total comments: 4

Patch Set 2 : #

Messages

Total messages: 10 (4 generated)
kozy
Dmitry, please take a look.
4 years, 8 months ago (2016-04-07 17:56:10 UTC) #2
dgozman
lgtm https://codereview.chromium.org/1867903002/diff/20001/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp File third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp (right): https://codereview.chromium.org/1867903002/diff/20001/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp#newcode93 third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp:93: *errorString = "Invalid context id: 0"; Cannot find ...
4 years, 8 months ago (2016-04-07 17:59:09 UTC) #3
kozy
All done! https://codereview.chromium.org/1867903002/diff/20001/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp File third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp (right): https://codereview.chromium.org/1867903002/diff/20001/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp#newcode93 third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp:93: *errorString = "Invalid context id: 0"; On ...
4 years, 8 months ago (2016-04-07 18:07:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867903002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867903002/40001
4 years, 8 months ago (2016-04-07 18:08:09 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 8 months ago (2016-04-07 19:31:04 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 19:32:00 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d3e1f6b795170d0cb6a160f5193ddd2b89c812b5
Cr-Commit-Position: refs/heads/master@{#385839}

Powered by Google App Engine
This is Rietveld 408576698