third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-evaluate-with-context-id-equal-zero.html - Issue 1867903002: [DevTools] Fix crash when runtime.evaluate is called with contextId = 0

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-evaluate-with-context-id-equal-zero.html

Issue 1867903002: [DevTools] Fix crash when runtime.evaluate is called with contextId = 0 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-evaluate-with-context-id-equal-zero-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-evaluate-with-context-id-equal-zero.html

diff --git a/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-evaluate-in-default-context.html b/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-evaluate-with-context-id-equal-zero.html

similarity index 57%

copy from third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-evaluate-in-default-context.html

copy to third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-evaluate-with-context-id-equal-zero.html

index b500422ae656b4621c4a60f3a80512fb262a0805..e2e2b98a9809975a6db6e9a48f59d077ffee0398 100644

--- a/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-evaluate-in-default-context.html

+++ b/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-evaluate-with-context-id-equal-zero.html

@@ -5,7 +5,7 @@

function test()

{

- InspectorTest.sendCommand("Runtime.evaluate", { "expression": "window.a" }, evaluateCallback);

+ InspectorTest.sendCommand("Runtime.evaluate", { "contextId": 0, "expression": "" }, evaluateCallback);

function evaluateCallback(result)

{

@@ -16,8 +16,7 @@ function test()

}

</script>

</head>

-<body>

-Tests that default execution context is selected correctly.

-<iframe src="resources/runtime-events-iframe.html" onLoad="runTest();"></iframe>

+<body onLoad="runTest();">

+Tests that DevTools doesn't crash on Runtime.evaluate with contextId equals 0.

</body>

</html>