Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1867883003: Re-land (rebased for M50): Reset NACK/ACK list when parsing a new RTCP packet. (Closed)

Created:
4 years, 8 months ago by miu
Modified:
4 years, 8 months ago
Reviewers:
xjz
CC:
chromium-reviews, cbentzel+watch_chromium.org, imcheng+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, feature-media-reviews_chromium.org, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Re-land (rebased for M50): Reset NACK/ACK list when parsing a new RTCP packet. The NACK/ACK frames/packets list need to be reset before parsing each RTCP packet as the parser is shared by all RTCP packets on sender side. This caused the performance regression and potentially video freezing as well. TBR=xjz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=600527 Review URL: https://codereview.chromium.org/1853253003 Cr-Commit-Position: refs/heads/master@{#385046} (cherry picked from commit 411ea14c10f64b67a25985619583a5331e724d57)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M media/cast/net/rtcp/rtcp_utility.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
miu
xjz: FYI. Attempt #2 to reland your fix.
4 years, 8 months ago (2016-04-07 21:37:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867883003/1
4 years, 8 months ago (2016-04-07 21:37:31 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 21:38:29 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698