Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1867883002: Fix a bunch of memory issues in Vulkan (Closed)

Created:
4 years, 8 months ago by egdaniel
Modified:
4 years, 8 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@vkValgrind
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M src/gpu/vk/GrVkBackendContext.cpp View 3 chunks +3 lines, -0 lines 0 comments Download
M src/gpu/vk/GrVkExtensions.cpp View 6 chunks +6 lines, -0 lines 0 comments Download
M src/gpu/vk/GrVkGpu.cpp View 1 chunk +5 lines, -2 lines 1 comment Download
M src/gpu/vk/GrVkPipelineState.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/vk/GrVkPipelineStateBuilder.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (4 generated)
egdaniel
4 years, 8 months ago (2016-04-07 17:00:46 UTC) #3
jvanverth1
lgtm https://codereview.chromium.org/1867883002/diff/1/src/gpu/vk/GrVkGpu.cpp File src/gpu/vk/GrVkGpu.cpp (right): https://codereview.chromium.org/1867883002/diff/1/src/gpu/vk/GrVkGpu.cpp#newcode1216 src/gpu/vk/GrVkGpu.cpp:1216: dstRect.fRight = dstPoint.fX + srcRect.width(); whoops
4 years, 8 months ago (2016-04-07 17:03:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867883002/1
4 years, 8 months ago (2016-04-07 17:06:48 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 17:17:50 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8af936d3047208def585b7bc824f013b994f6312

Powered by Google App Engine
This is Rietveld 408576698