Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1392)

Side by Side Diff: src/gpu/vk/GrVkPipelineStateBuilder.cpp

Issue 1867883002: Fix a bunch of memory issues in Vulkan (Closed) Base URL: https://skia.googlesource.com/skia.git@vkValgrind
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« src/gpu/vk/GrVkGpu.cpp ('K') | « src/gpu/vk/GrVkPipelineState.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 Google Inc. 2 * Copyright 2016 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "vk/GrVkPipelineStateBuilder.h" 8 #include "vk/GrVkPipelineStateBuilder.h"
9 9
10 #include "vk/GrVkGpu.h" 10 #include "vk/GrVkGpu.h"
(...skipping 266 matching lines...) Expand 10 before | Expand all | Expand 10 after
277 GR_VK_CALL(fGpu->vkInterface(), DestroyShaderModule(fGpu->device(), fragShad erModule, 277 GR_VK_CALL(fGpu->vkInterface(), DestroyShaderModule(fGpu->device(), fragShad erModule,
278 nullptr)); 278 nullptr));
279 279
280 if (!pipeline) { 280 if (!pipeline) {
281 GR_VK_CALL(fGpu->vkInterface(), DestroyPipelineLayout(fGpu->device(), pi pelineLayout, 281 GR_VK_CALL(fGpu->vkInterface(), DestroyPipelineLayout(fGpu->device(), pi pelineLayout,
282 nullptr)); 282 nullptr));
283 GR_VK_CALL(fGpu->vkInterface(), DestroyDescriptorSetLayout(fGpu->device( ), dsLayout[0], 283 GR_VK_CALL(fGpu->vkInterface(), DestroyDescriptorSetLayout(fGpu->device( ), dsLayout[0],
284 nullptr)); 284 nullptr));
285 GR_VK_CALL(fGpu->vkInterface(), DestroyDescriptorSetLayout(fGpu->device( ), dsLayout[1], 285 GR_VK_CALL(fGpu->vkInterface(), DestroyDescriptorSetLayout(fGpu->device( ), dsLayout[1],
286 nullptr)); 286 nullptr));
287 this->cleanupFragmentProcessors();
287 return nullptr; 288 return nullptr;
288 } 289 }
289 290
290 return new GrVkPipelineState(fGpu, 291 return new GrVkPipelineState(fGpu,
291 desc, 292 desc,
292 pipeline, 293 pipeline,
293 pipelineLayout, 294 pipelineLayout,
294 dsLayout, 295 dsLayout,
295 fUniformHandles, 296 fUniformHandles,
296 fUniformHandler.fUniforms, 297 fUniformHandler.fUniforms,
297 fUniformHandler.fCurrentVertexUBOOffset, 298 fUniformHandler.fCurrentVertexUBOOffset,
298 fUniformHandler.fCurrentFragmentUBOOffset, 299 fUniformHandler.fCurrentFragmentUBOOffset,
299 numSamplers, 300 numSamplers,
300 fGeometryProcessor, 301 fGeometryProcessor,
301 fXferProcessor, 302 fXferProcessor,
302 fFragmentProcessors); 303 fFragmentProcessors);
303 } 304 }
OLDNEW
« src/gpu/vk/GrVkGpu.cpp ('K') | « src/gpu/vk/GrVkPipelineState.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698