Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1867793003: Do not use U+0000 as the invalid code point. (Closed)

Created:
4 years, 8 months ago by Seigo Nonaka
Modified:
4 years, 8 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not use U+0000 as the invalid code point. BUG=594923 Committed: https://crrev.com/6cf6afe232bebf2e9305fd87e71addcd739145fa Cr-Commit-Position: refs/heads/master@{#385708}

Patch Set 1 #

Patch Set 2 : rebase #

Messages

Total messages: 14 (6 generated)
Seigo Nonaka
Hi Yosi-san, I'm sorry for my misunderstanding. Could you kindly take a look? thank you.
4 years, 8 months ago (2016-04-07 08:58:14 UTC) #2
yosin_UTC9
lgtm
4 years, 8 months ago (2016-04-07 09:54:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867793003/1
4 years, 8 months ago (2016-04-07 09:54:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/155875) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 8 months ago (2016-04-07 09:57:05 UTC) #7
Seigo Nonaka
Thank you for your review! Going to rebase and submit again...
4 years, 8 months ago (2016-04-07 09:58:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867793003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867793003/20001
4 years, 8 months ago (2016-04-07 10:00:56 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-07 10:59:19 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 11:00:46 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6cf6afe232bebf2e9305fd87e71addcd739145fa
Cr-Commit-Position: refs/heads/master@{#385708}

Powered by Google App Engine
This is Rietveld 408576698