Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: third_party/WebKit/Source/core/editing/state_machines/ForwardGraphemeBoundaryStateMachineTest.cpp

Issue 1867793003: Do not use U+0000 as the invalid code point. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/editing/state_machines/ForwardGraphemeBoundaryStateMachine.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/state_machines/ForwardGraphemeBoundaryStateMachineTest.cpp
diff --git a/third_party/WebKit/Source/core/editing/state_machines/ForwardGraphemeBoundaryStateMachineTest.cpp b/third_party/WebKit/Source/core/editing/state_machines/ForwardGraphemeBoundaryStateMachineTest.cpp
index f27ecafce8abd8b3e7aee43e6fc2d2f93110a763..cdbb8c2d33c43db60168193bf0c29f66b373001b 100644
--- a/third_party/WebKit/Source/core/editing/state_machines/ForwardGraphemeBoundaryStateMachineTest.cpp
+++ b/third_party/WebKit/Source/core/editing/state_machines/ForwardGraphemeBoundaryStateMachineTest.cpp
@@ -66,6 +66,18 @@ TEST(ForwardGraphemeBoundaryStatemachineTest, PrecedingText)
{ kRisU, kRisS }, { 'a', 'a' }));
EXPECT_EQ(1, machine.finalizeAndGetBoundaryOffset());
+ // U+0000 + | + 'a' + 'a'
+ EXPECT_EQ("SRF", processSequenceForward(&machine, { 0 }, { 'a', 'a' }));
+ EXPECT_EQ(1, machine.finalizeAndGetBoundaryOffset());
+ // U+0000 + [U] + | + 'a' + 'a'
+ EXPECT_EQ("RRSRF", processSequenceForward(&machine,
+ { 0, kRisU }, { 'a', 'a' }));
+ EXPECT_EQ(1, machine.finalizeAndGetBoundaryOffset());
+ // U+0000 + [U] + [S] + | + 'a' + 'a'
+ EXPECT_EQ("RRRRSRF", processSequenceForward(&machine,
+ { 0, kRisU, kRisS }, { 'a', 'a' }));
+ EXPECT_EQ(1, machine.finalizeAndGetBoundaryOffset());
+
// 'a' + | + 'a' + 'a'
EXPECT_EQ("SRF", processSequenceForward(&machine, { 'a' }, { 'a', 'a' }));
EXPECT_EQ(1, machine.finalizeAndGetBoundaryOffset());
@@ -170,6 +182,10 @@ TEST(ForwardGraphemeBoundaryStatemachineTest, BreakImmediately_BMP)
const std::vector<UChar32> kEmpty;
ForwardGraphemeBoundaryStateMachine machine;
+ // SOT + | + U+0000 + U+0000
+ EXPECT_EQ("SRF", processSequenceForward(&machine, kEmpty, { 0, 0 }));
+ EXPECT_EQ(1, machine.finalizeAndGetBoundaryOffset());
+
// SOT + | + 'a' + 'a'
EXPECT_EQ("SRF", processSequenceForward(&machine, kEmpty, { 'a', 'a' }));
EXPECT_EQ(1, machine.finalizeAndGetBoundaryOffset());
« no previous file with comments | « third_party/WebKit/Source/core/editing/state_machines/ForwardGraphemeBoundaryStateMachine.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698