[Binding] use V8TRYCATCH_VOID and raw pointer in indexed setter

[Binding] use V8TRYCATCH_VOID and raw pointer in indexed setter

We use V8TRYCATCH_VOID when we assign converted JS value
into native variable, and the native variable type is
raw pointer if the type is not primitive.
(occur in attribute setter and function)

However, in generated indexed setter
they are simple assignment without try-catch and variable type is RefPtr.

This patch unify the situation by using V8TRYCATCH_VOID and raw pointer.

R=haraken@chromium.org
BUG=239771
TEST=TestEventTarget.idl

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153567

[kojih, 2013-07-04 08:14:50]

r?

Example of V8TRYCATCH_VOID and raw pointer:
https://code.google.com/p/chromium/codesearch#chromium/src/out/Debug/obj/gen/...

This CL is necessary for reducing various kind of GetNativeType and creating
common JSValueToNative.


Diff of generated code:

diff -u /mnt/hdd/diff/gen_master/V8HTMLOptionsCollection.cpp
/mnt/hdd/diff/gen_js0/V8HTMLOptionsCollection.cpp
--- /mnt/hdd/diff/gen_master/V8HTMLOptionsCollection.cpp        2013-07-04
14:18:51.201158471 +0900
+++ /mnt/hdd/diff/gen_js0/V8HTMLOptionsCollection.cpp   2013-07-04
16:37:26.148856428 +0900
@@ -156,7 +156,7 @@
 static void indexedPropertySetter(uint32_t index, v8::Local<v8::Value> value,
const v8::PropertyCallbackInfo<v8::Value>& info)
 {
     HTMLOptionsCollection* collection =
V8HTMLOptionsCollection::toNative(info.Holder());
-    RefPtr<HTMLOptionElement> propertyValue =
V8HTMLOptionElement::HasInstance(value, info.GetIsolate(),
worldType(info.GetIsolate())) ?
V8HTMLOptionElement::toNative(v8::Handle<v8::Object>::Cast(value)) : 0;
+    V8TRYCATCH_VOID(HTMLOptionElement*, propertyValue,
V8HTMLOptionElement::HasInstance(value, info.GetIsolate(),
worldType(info.GetIsolate())) ?
V8HTMLOptionElement::toNative(v8::Handle<v8::Object>::Cast(value)) : 0);
     ExceptionCode ec = 0;
     bool result;
     if (value->IsNull())
@@ -164,7 +164,7 @@
     else if (value->IsUndefined())
         result = collection->anonymousIndexedSetterRemove(index, ec);
     else
-        result = collection->anonymousIndexedSetter(index,
propertyValue.release(), ec);
+        result = collection->anonymousIndexedSetter(index, propertyValue, ec);
     if (!result)
         return;
     if (ec) {
diff -u /mnt/hdd/diff/gen_master/V8HTMLSelectElement.cpp
/mnt/hdd/diff/gen_js0/V8HTMLSelectElement.cpp
--- /mnt/hdd/diff/gen_master/V8HTMLSelectElement.cpp    2013-07-04
14:18:51.201158471 +0900
+++ /mnt/hdd/diff/gen_js0/V8HTMLSelectElement.cpp       2013-07-04
16:37:26.148856428 +0900
@@ -532,9 +532,9 @@
 static void indexedPropertySetter(uint32_t index, v8::Local<v8::Value> value,
const v8::PropertyCallbackInfo<v8::Value>& info)
 {
     HTMLSelectElement* collection =
V8HTMLSelectElement::toNative(info.Holder());
-    RefPtr<HTMLOptionElement> propertyValue =
V8HTMLOptionElement::HasInstance(value, info.GetIsolate(),
worldType(info.GetIsolate())) ?
V8HTMLOptionElement::toNative(v8::Handle<v8::Object>::Cast(value)) : 0;
+    V8TRYCATCH_VOID(HTMLOptionElement*, propertyValue,
V8HTMLOptionElement::HasInstance(value, info.GetIsolate(),
worldType(info.GetIsolate())) ?
V8HTMLOptionElement::toNative(v8::Handle<v8::Object>::Cast(value)) : 0);
     ExceptionCode ec = 0;
-    bool result = collection->anonymousIndexedSetter(index,
propertyValue.release(), ec);
+    bool result = collection->anonymousIndexedSetter(index, propertyValue, ec);
     if (!result)
         return;
     if (ec) {

[haraken, 2013-07-04 08:22:38]

https://codereview.chromium.org/18677002/diff/1/Source/bindings/scripts/CodeG...
File Source/bindings/scripts/CodeGeneratorV8.pm (left):

https://codereview.chromium.org/18677002/diff/1/Source/bindings/scripts/CodeG...
Source/bindings/scripts/CodeGeneratorV8.pm:3355: $passNativeValue .=
".release()" if (IsRefPtrType($type));

Why can you remove this?

https://codereview.chromium.org/18677002/diff/1/Source/bindings/scripts/CodeG...
File Source/bindings/scripts/CodeGeneratorV8.pm (right):

https://codereview.chromium.org/18677002/diff/1/Source/bindings/scripts/CodeG...
Source/bindings/scripts/CodeGeneratorV8.pm:3650: my $nativeType =
GetNativeType($parameter->type, 1);

I hope this could be "parameter" instead of mysterious "1", but you will anyway
clean it up when landing the Python generator :)

https://codereview.chromium.org/18677002/diff/1/Source/bindings/scripts/CodeG...
Source/bindings/scripts/CodeGeneratorV8.pm:3662: $code .= "   
V8TRYCATCH_VOID(${nativeType}, ${nativeValueName}, ${nativeValue});\n";

Looks correct but this might affect performance due to the v8::TryCatch
overhead. Please watch the perf bot when landing.

[kojih, 2013-07-04 08:30:42]

https://codereview.chromium.org/18677002/diff/1/Source/bindings/scripts/CodeG...
File Source/bindings/scripts/CodeGeneratorV8.pm (left):

https://codereview.chromium.org/18677002/diff/1/Source/bindings/scripts/CodeG...
Source/bindings/scripts/CodeGeneratorV8.pm:3355: $passNativeValue .=
".release()" if (IsRefPtrType($type));
Since this patch changes propertyValue type from RefPtr to raw pointer,
".release" is unnecessary.

https://codereview.chromium.org/18677002/diff/1/Source/bindings/scripts/CodeG...
File Source/bindings/scripts/CodeGeneratorV8.pm (right):

https://codereview.chromium.org/18677002/diff/1/Source/bindings/scripts/CodeG...
Source/bindings/scripts/CodeGeneratorV8.pm:3650: my $nativeType =
GetNativeType($parameter->type, 1);
OK, in python generator, this will be named parameter such as
used_as_parameter=True.

https://codereview.chromium.org/18677002/diff/1/Source/bindings/scripts/CodeG...
Source/bindings/scripts/CodeGeneratorV8.pm:3662: $code .= "   
V8TRYCATCH_VOID(${nativeType}, ${nativeValueName}, ${nativeValue});\n";
OK.

[haraken, 2013-07-04 08:33:03]

Makes sense. LGTM.

[commit-bot: I haz the power, 2013-07-04 08:34:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kojih@chromium.org/18677002/1

[commit-bot: I haz the power, 2013-07-04 09:50:27]

Change committed as 153567