[Binding] use V8TRYCATCH_VOID and raw pointer in indexed setter

Source/bindings/scripts/CodeGeneratorV8.pm

 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com>
 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org>
 # Copyright (C) 2006 Apple Computer, Inc.
 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc.
 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
 # Copyright (C) Research In Motion Limited 2010. All rights reserved.
 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
 # Copyright (C) 2012 Ericsson AB. All rights reserved.
@@ skipping 3333 matching lines @@
     my $code = "static void indexedPropertySetter(uint32_t index, v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<v8::Value>& info)\n";
     $code .= "{\n";
     $code .= "    ${implClassName}* collection = ${v8ClassName}::toNative(info.Holder());\n";
     $code .= GenerateNativeValueDefinition($indexedSetterFunction, $indexedSetterFunction->parameters->[1], "value", "propertyValue", "info.GetIsolate()");
 
     my $extraArguments = "";
     if ($raisesExceptions) {
         $code .= "    ExceptionCode ec = 0;\n";
         $extraArguments = ", ec";
     }
-    my $passNativeValue = "propertyValue";
-    $passNativeValue .= ".release()" if (IsRefPtrType($type));

[haraken, 2013/07/04 08:22:38]

Why can you remove this?

[kojih, 2013/07/04 08:30:42]

Since this patch changes propertyValue type from RefPtr to raw pointer,
".release" is unnecessary.

-
     my @conditions = ();
     my @statements = ();
     if ($treatNullAs && $treatNullAs ne "NullString") {
         push @conditions, "value->IsNull()";
         push @statements, "collection->${treatNullAs}(index$extraArguments);";
     }
     if ($treatUndefinedAs && $treatUndefinedAs ne "NullString") {
         push @conditions, "value->IsUndefined()";
         push @statements, "collection->${treatUndefinedAs}(index$extraArguments);";
     }
     push @conditions, "";
-    push @statements, "collection->${methodName}(index, $passNativeValue$extraArguments);";
+    push @statements, "collection->${methodName}(index, propertyValue$extraArguments);";
     $code .= GenerateIfElseStatement("bool", "result", \@conditions, \@statements);
 
     $code .= "    if (!result)\n";
     $code .= "        return;\n";
     if ($raisesExceptions) {
         $code .= "    if (ec) {\n";
         $code .= "        setDOMException(ec, info.GetIsolate());\n";
         $code .= "        return;\n";
         $code .= "    }\n";
     }
@@ skipping 264 matching lines @@
 {
     my $function = shift;
     my $parameter = shift;
     my $jsValue = shift;
     my $nativeValueName = shift;
     my $getIsolate = shift;
 
     my $treatNullAs = $parameter->extendedAttributes->{"TreatNullAs"} || "";
     my $treatUndefinedAs = $parameter->extendedAttributes->{"TreatUndefinedAs"} || "";
     my $code = "";
-    my $nativeType = GetNativeType($parameter->type);
+    my $nativeType = GetNativeType($parameter->type, 1);

[haraken, 2013/07/04 08:22:38]

I hope this could be "parameter" instead of mysterious "1", but you will anyway
clean it up when landing the Python generator :)

[kojih, 2013/07/04 08:30:42]

OK, in python generator, this will be named parameter such as
used_as_parameter=True.

     my $nativeValue = JSValueToNative($parameter->type, $function->extendedAttributes, $jsValue, $getIsolate);
     if ($parameter->type eq "DOMString") {
         my $nullCheck = "";
         if ($treatNullAs eq "NullString") {
             $nullCheck = "WithUndefinedOrNullCheck";
             if ($treatUndefinedAs eq "NullString") {
                 $nullCheck = "WithNullCheck";
             }
         }
         $code .= "    V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<${nullCheck}>, ${nativeValueName}, ${jsValue});\n";
     } else {
-        $code .= "    ${nativeType} ${nativeValueName} = ${nativeValue};\n";
+        $code .= "    V8TRYCATCH_VOID(${nativeType}, ${nativeValueName}, ${nativeValue});\n";

[haraken, 2013/07/04 08:22:38]

Looks correct but this might affect performance due to the v8::TryCatch
overhead. Please watch the perf bot when landing.

[kojih, 2013/07/04 08:30:42]

OK.

     }
     return $code;
 }
 
 sub GenerateImplementationNamedPropertySetter
 {
     my $interface = shift;
     my $namedSetterFunction = shift;
     my $implClassName = GetImplName($interface);
     my $v8ClassName = GetV8ClassName($interface);
@@ skipping 2375 matching lines @@
         if ($currentInterface->extendedAttributes->{$extendedAttribute}) {
             $found = 1;
         }
         return 1 if $found;
     }, 0);
 
     return $found;
 }
 
 1;