Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issue 1867563003: Go system tests: Sets the environment variable GODEBUG=cgocheck=2. (Closed)

Created:
4 years, 8 months ago by rudominer
Modified:
4 years, 8 months ago
Reviewers:
jamesr, viettrungluu
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Go system tests: Sets the environment variable GODEBUG=cgocheck=2. Setting this causes the Go runtime to do extra tests for conformance to the rules for passing pointers in CGO. We add the ability to set an environment dictionary in get_test_list.py and use this to set GODEBUG. BUG=#484 R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c6e5232fe13d6235be51b558b85e16e5c1ecbd11

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M mojo/tools/get_test_list.py View 2 chunks +6 lines, -3 lines 0 comments Download
M mojo/tools/mojob.py View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
rudominer
ptal Trung including you because I changed get_test_list.py
4 years, 8 months ago (2016-04-06 20:18:54 UTC) #6
jamesr
lgtm
4 years, 8 months ago (2016-04-06 21:54:30 UTC) #7
rudominer
Trung I'm going to go ahead and land this. If there is something you don't ...
4 years, 8 months ago (2016-04-08 18:21:00 UTC) #8
rudominer
4 years, 8 months ago (2016-04-08 18:23:22 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
c6e5232fe13d6235be51b558b85e16e5c1ecbd11 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698