Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: mojo/tools/get_test_list.py

Issue 1867563003: Go system tests: Sets the environment variable GODEBUG=cgocheck=2. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/tools/mojob.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/tools/get_test_list.py
diff --git a/mojo/tools/get_test_list.py b/mojo/tools/get_test_list.py
index f8ea8cab765c36eff83b00baf92bd332e62df6b4..6048327cda1b3e0824733ab43259d40af03f1e7f 100755
--- a/mojo/tools/get_test_list.py
+++ b/mojo/tools/get_test_list.py
@@ -52,12 +52,14 @@ def GetTestList(config, verbose_count=0):
return not types_to_run.isdisjoint(this_tests_types)
# Call this to add the given command to the test list.
- def AddEntry(name, command):
+ # |env| is an optional dictionary to be used to update the environment for
+ # the test process.
+ def AddEntry(name, command, env=None):
if config.sanitizer == Config.SANITIZER_ASAN:
command = (["python", os.path.join("mojo", "tools",
"run_command_through_symbolizer.py")] +
command)
- test_list.append({"name": name, "command": command})
+ test_list.append({"name": name, "command": command, "env" : env})
# Call this to add the given command to the test list. If appropriate, the
# command will be run under xvfb.
@@ -128,7 +130,8 @@ def GetTestList(config, verbose_count=0):
ShouldRunTest(Config.TEST_TYPE_DEFAULT, Config.TEST_TYPE_UNIT, "go")):
# Go system tests:
AddEntry("Go system tests",
- [os.path.join(build_dir, "obj", "mojo", "go", "system_test")])
+ [os.path.join(build_dir, "obj", "mojo", "go", "system_test")],
+ env={'GODEBUG' : 'cgocheck=2'})
# Pure Go unit tests:
assert paths.go_tool_path is not None
« no previous file with comments | « no previous file | mojo/tools/mojob.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698