Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Unified Diff: third_party/WebKit/Source/devtools/front_end/externs.js

Issue 1867523002: Rename ignore_cache and ignoreCache to bypass* unless it affects API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/externs.js
diff --git a/third_party/WebKit/Source/devtools/front_end/externs.js b/third_party/WebKit/Source/devtools/front_end/externs.js
index 8933a5f1c2aafe3899ade9865e3cc3ed3fc72846..9899dd1fa59443f5b8d77a63f1041916d056368b 100644
--- a/third_party/WebKit/Source/devtools/front_end/externs.js
+++ b/third_party/WebKit/Source/devtools/front_end/externs.js
@@ -295,6 +295,8 @@ function ExtensionDescriptor() {
* @constructor
*/
function ExtensionReloadOptions() {
+ // TODO(toyoshim): Check if this ignoreCache shouldn't be changed for
+ // DevTools protocol. Also, how this prototype is used actually?
Takashi Toyoshima 2016/04/06 09:36:23 I can not find any caller that uses this function
dgozman 2016/04/06 15:44:19 This is for type checking. It's mentioned in Exten
Takashi Toyoshima 2016/04/08 04:50:55 Thanks!
this.ignoreCache = false;
this.injectedScript = "";
this.userAgent = "";

Powered by Google App Engine
This is Rietveld 408576698