third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js - Issue 1867523002: Rename ignore_cache and ignoreCache to bypass* unless it affects API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js

Issue 1867523002: Rename ignore_cache and ignoreCache to bypass* unless it affects API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/inspector/extensions-ignore-cache.html ('K') | « third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp ('k') | third_party/WebKit/Source/devtools/front_end/externs.js » ('j') | third_party/WebKit/Source/devtools/front_end/externs.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js

diff --git a/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js b/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js

index bfeb759389c496ab8563a8ad231a12065eeb9ff6..16b19453d5efe916df13f3e2c944adb73b67e52f 100644

--- a/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js

+++ b/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js

@@ -429,6 +429,8 @@ WebInspector.ExtensionServer.prototype = {

var injectedScript;

if (options.injectedScript)

injectedScript = "(function(){" + options.injectedScript + "})()";

+ // TODO(toyoshim): Check if this ignoreCache shouldn't be changed for

dgozman 2016/04/06 15:44:19 This is a public API.

Takashi Toyoshima 2016/04/08 04:50:55 Acknowledged.

+ // DevTools protocol.

WebInspector.targetManager.reloadPage(!!options.ignoreCache, injectedScript);

return this._status.OK();

@@ -1087,4 +1089,4 @@ WebInspector.extensionAPI = {};

defineCommonExtensionSymbols(WebInspector.extensionAPI);

/** @type {!WebInspector.ExtensionServer} */

-WebInspector.extensionServer;

+WebInspector.extensionServer;