Mojo: Align string sizes when serializing a native type.

Mojo: Align string sizes when serializing a native type.

When determining the serialized size of a string field of a Mojo struct
with a typemapped type, that size is not aligned. When serializing that
string, each allocation in the buffer is aligned to 8 bytes. This can
result in the buffer requiring a re-allocation to accommodate the actual
serialized size and failed DCHECKs. This CL fixes this by aligning each
string size.

Committed: https://crrev.com/1953e4dd01ffe90142c2b0ff810c661f4bdbc1f6
Cr-Commit-Position: refs/heads/master@{#385589}

[Sam McNally, 2016-04-06 07:35:15]

Patchset #1 (id:1) has been deleted

[Sam McNally, 2016-04-06 07:35:25]

Patchset #1 (id:20001) has been deleted

[Sam McNally, 2016-04-06 07:35:33]

Patchset #1 (id:40001) has been deleted

[Sam McNally, 2016-04-06 07:35:40]

Patchset #1 (id:60001) has been deleted

[Sam McNally, 2016-04-06 08:12:05]

Description was changed from

==========
Mojo: Align string sizes when serializing from a native type.

When determining the serialized size of a string field of a Mojo struct
with a typemapped type, that size is not aligned. When serializing that
string, each allocation in the buffer is aligned to 8 bytes. This can
result in the buffer requiring a re-allocation to accommodate the actual
serialized size and failed DCHECKs. This CL fixes this by aligning each
string size.
==========

to

==========
Mojo: Align string sizes when serializing a native type.

When determining the serialized size of a string field of a Mojo struct
with a typemapped type, that size is not aligned. When serializing that
string, each allocation in the buffer is aligned to 8 bytes. This can
result in the buffer requiring a re-allocation to accommodate the actual
serialized size and failed DCHECKs. This CL fixes this by aligning each
string size.
==========

[Sam McNally, 2016-04-06 08:12:27]

sammc@chromium.org changed reviewers:
+ rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-04-06 14:54:59]

lgtm

https://codereview.chromium.org/1867483002/diff/80001/mojo/mojom_bindings_gen...
File mojo/mojom_bindings_generator_explicit.gypi (right):

https://codereview.chromium.org/1867483002/diff/80001/mojo/mojom_bindings_gen...
mojo/mojom_bindings_generator_explicit.gypi:82:
'<(SHARED_INTERMEDIATE_DIR)/mojo/public/tools/bindings/cpp_templates.zip',
Heh, this probably explains a weird error I only saw once when messing with the
bindings generator.

https://codereview.chromium.org/1867483002/diff/80001/mojo/public/tools/bindi...
File mojo/public/tools/bindings/bindings.gyp (right):

https://codereview.chromium.org/1867483002/diff/80001/mojo/public/tools/bindi...
mojo/public/tools/bindings/bindings.gyp:32:
'generators/cpp_templates/struct_serialization_declaration.tmpl',
or this

[Sam McNally, 2016-04-06 22:17:41]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2016-04-06 22:18:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867483002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867483002/80001

[commit-bot: I haz the power, 2016-04-06 23:54:33]

Description was changed from

==========
Mojo: Align string sizes when serializing a native type.

When determining the serialized size of a string field of a Mojo struct
with a typemapped type, that size is not aligned. When serializing that
string, each allocation in the buffer is aligned to 8 bytes. This can
result in the buffer requiring a re-allocation to accommodate the actual
serialized size and failed DCHECKs. This CL fixes this by aligning each
string size.
==========

to

==========
Mojo: Align string sizes when serializing a native type.

When determining the serialized size of a string field of a Mojo struct
with a typemapped type, that size is not aligned. When serializing that
string, each allocation in the buffer is aligned to 8 bytes. This can
result in the buffer requiring a re-allocation to accommodate the actual
serialized size and failed DCHECKs. This CL fixes this by aligning each
string size.
==========

[commit-bot: I haz the power, 2016-04-06 23:54:35]

Committed patchset #1 (id:80001)

[commit-bot: I haz the power, 2016-04-06 23:56:31]

Description was changed from

==========
Mojo: Align string sizes when serializing a native type.

When determining the serialized size of a string field of a Mojo struct
with a typemapped type, that size is not aligned. When serializing that
string, each allocation in the buffer is aligned to 8 bytes. This can
result in the buffer requiring a re-allocation to accommodate the actual
serialized size and failed DCHECKs. This CL fixes this by aligning each
string size.
==========

to

==========
Mojo: Align string sizes when serializing a native type.

When determining the serialized size of a string field of a Mojo struct
with a typemapped type, that size is not aligned. When serializing that
string, each allocation in the buffer is aligned to 8 bytes. This can
result in the buffer requiring a re-allocation to accommodate the actual
serialized size and failed DCHECKs. This CL fixes this by aligning each
string size.

Committed: https://crrev.com/1953e4dd01ffe90142c2b0ff810c661f4bdbc1f6
Cr-Commit-Position: refs/heads/master@{#385589}
==========

[commit-bot: I haz the power, 2016-04-06 23:56:32]

Patchset 1 (id:??) landed as
https://crrev.com/1953e4dd01ffe90142c2b0ff810c661f4bdbc1f6
Cr-Commit-Position: refs/heads/master@{#385589}