mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.cc - Issue 1867483002: Mojo: Align string sizes when serializing a native type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.cc

Issue 1867483002: Mojo: Align string sizes when serializing a native type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/mojom_bindings_generator_explicit.gypi ('K') | « mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.h ('k') | mojo/public/interfaces/bindings/tests/struct_with_traits.mojom » ('j') | mojo/public/tools/bindings/bindings.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.cc

diff --git a/mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.cc b/mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.cc

index f58ce84652ba81bfd161073a0a7ee6ea96343c6a..8d4f97d43fffa05a1ad881936725a9d2ba592207 100644

--- a/mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.cc

+++ b/mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.cc

@@ -15,7 +15,7 @@ bool StructTraits<test::StructWithTraits, test::StructWithTraitsImpl>::Read(

out->set_uint32(r.f_uint32());

out->set_uint64(r.f_uint64());

out->set_string(r.f_string().as_string());

- return true;

+ return r.f_string() == r.f_string2();

}

} // namespace mojo