Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Issue 1867333003: Fix Mac build, format breakage (Closed)

Created:
4 years, 8 months ago by JF
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix Mac build, format breakage This CL: https://codereview.chromium.org/1869433004 Updated printf format checks, but apparently some of the builds aren't hit by the bots. The Mac build is now sad. R= jochen@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/x64/disasm-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
JF
4 years, 8 months ago (2016-04-08 15:37:52 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867333003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867333003/1
4 years, 8 months ago (2016-04-08 15:38:55 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-08 15:47:06 UTC) #4
JF
Looks like the Windows bots are also sad, I'm not sure it's the same issue ...
4 years, 8 months ago (2016-04-08 15:55:28 UTC) #5
JF
4 years, 8 months ago (2016-04-08 16:08:20 UTC) #7
I think the Windows failures are a separate issue. I'll revert my other patch
and cancel this one since it'll conflicts with the revert.

Powered by Google App Engine
This is Rietveld 408576698