Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: content/browser/service_worker/service_worker_controllee_request_handler.h

Issue 1867293004: Set service worker response info data for foreign fetch intercepted fetches. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ff-check-origin
Patch Set: address comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_controllee_request_handler.h
diff --git a/content/browser/service_worker/service_worker_controllee_request_handler.h b/content/browser/service_worker/service_worker_controllee_request_handler.h
index 736f1b5ea5cfe95bad1730aa540ae88c070d5425..8a168e4aee4afcba33ffaef2a8a1c587d10075e0 100644
--- a/content/browser/service_worker/service_worker_controllee_request_handler.h
+++ b/content/browser/service_worker/service_worker_controllee_request_handler.h
@@ -57,8 +57,6 @@ class CONTENT_EXPORT ServiceWorkerControlleeRequestHandler
net::NetworkDelegate* network_delegate,
ResourceContext* resource_context) override;
- void GetExtraResponseInfo(ResourceResponseInfo* response_info) const override;
-
private:
FRIEND_TEST_ALL_PREFIXES(ServiceWorkerControlleeRequestHandlerTest,
ActivateWaitingVersion);
@@ -89,20 +87,7 @@ class CONTENT_EXPORT ServiceWorkerControlleeRequestHandler
// Called just before the request is restarted. Makes sure the next request
// goes over the network.
- void OnPrepareToRestart(base::TimeTicks service_worker_start_time,
- base::TimeTicks service_worker_ready_time) override;
-
- // Called when the request's start phase completes. Caches response info for
- // GetExtraResponseInfo.
- void OnStartCompleted(
- bool was_fetched_via_service_worker,
- bool was_fallback_required,
- const GURL& original_url_via_service_worker,
- blink::WebServiceWorkerResponseType response_type_via_service_worker,
- base::TimeTicks worker_start_time,
- base::TimeTicks service_worker_ready_time,
- bool response_is_in_cache_storage,
- const std::string& response_cache_storage_cache_name) override;
+ void OnPrepareToRestart() override;
ServiceWorkerVersion* GetServiceWorkerVersion(
ServiceWorkerMetrics::URLRequestJobResult* result) override;
@@ -131,16 +116,6 @@ class CONTENT_EXPORT ServiceWorkerControlleeRequestHandler
// next intercept opportunity, for main frame requests.
bool use_network_;
- // Cached metadata for GetExtraResponseInfo.
- bool was_fetched_via_service_worker_;
- bool was_fallback_required_;
- GURL original_url_via_service_worker_;
- blink::WebServiceWorkerResponseType response_type_via_service_worker_;
- base::TimeTicks service_worker_start_time_;
- base::TimeTicks service_worker_ready_time_;
- bool response_is_in_cache_storage_ = false;
- std::string response_cache_storage_cache_name_;
-
base::WeakPtrFactory<ServiceWorkerControlleeRequestHandler> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(ServiceWorkerControlleeRequestHandler);

Powered by Google App Engine
This is Rietveld 408576698