Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 1867283002: Print name of previous test when a browser test times out. (Closed)

Created:
4 years, 8 months ago by Bill Hesse
Modified:
4 years, 8 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Print name of previous test when a browser test times out. Remove timeout multiplier for dart2js browser tests. BUG=https://github.com/dart-lang/sdk/issues/26060 R=kustermann@google.com Committed: https://github.com/dart-lang/sdk/commit/c0096e6f0c6c9aa9e2ce79df25debf5c91f95caa

Patch Set 1 #

Patch Set 2 : Remove revert of dart2js timeout multiplier. #

Patch Set 3 : Revert the correct file, not the wrong one. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/testing/dart/browser_controller.dart View 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Bill Hesse
I don't know why we didn't add this info years ago.
4 years, 8 months ago (2016-04-08 09:25:31 UTC) #2
ahe
Could we do this as two separate CLs? I find it hard to have a ...
4 years, 8 months ago (2016-04-08 09:55:15 UTC) #3
Bill Hesse
PTAL.
4 years, 8 months ago (2016-04-08 10:48:34 UTC) #4
Bill Hesse
Please take a look
4 years, 8 months ago (2016-04-12 16:34:01 UTC) #7
kustermann
lgtm Consider adding a TODO to changes like these to restore the original code once ...
4 years, 8 months ago (2016-04-13 09:22:12 UTC) #8
Bill Hesse
On 2016/04/13 09:22:12, kustermann wrote: > lgtm > > Consider adding a TODO to changes ...
4 years, 8 months ago (2016-04-13 10:33:36 UTC) #9
Bill Hesse
4 years, 8 months ago (2016-04-13 10:35:33 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
c0096e6f0c6c9aa9e2ce79df25debf5c91f95caa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698