Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: tools/testing/dart/browser_controller.dart

Issue 1867283002: Print name of previous test when a browser test times out. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Revert the correct file, not the wrong one. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/browser_controller.dart
diff --git a/tools/testing/dart/browser_controller.dart b/tools/testing/dart/browser_controller.dart
index 6e375499bf2f37690c0ecd93ce40d79157f0fb99..27765697ea3b74db45fe86f46381cd51199c2df6 100644
--- a/tools/testing/dart/browser_controller.dart
+++ b/tools/testing/dart/browser_controller.dart
@@ -1092,6 +1092,9 @@ class BrowserTestRunner {
if (status.currentTest.lastKnownMessage.length > 0) {
lastKnownMessage = status.currentTest.lastKnownMessage;
}
+ if (status.lastTest != null) {
+ lastKnownMessage += '\nPrevious test was ${status.lastTest.url}';
+ }
// Wait until the browser is closed before reporting the test as timeout.
// This will enable us to capture stdout/stderr from the browser
// (which might provide us with information about what went wrong).
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698