Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1867173002: Lighten incognito frame when inactive, instead of darkening it. (Closed)

Created:
4 years, 8 months ago by Peter Kasting
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Lighten incognito frame when inactive, instead of darkening it. BUG=599952 TEST=Run Chrome with --top-chrome-md=material on Linux, using the Classic theme. Open an incognito window and then deactivate it. The frame should lighten and the outlines around tabs should stay dark. Review URL: https://codereview.chromium.org/1862923002 Cr-Commit-Position: refs/heads/master@{#385593} (cherry picked from commit f549e90f4bf57b261f0f9db9971dc0193b433358) Committed: https://chromium.googlesource.com/chromium/src/+/6217e3d464614465e46080937f99e9fbf1dc08df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/themes/theme_properties.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Peter Kasting
4 years, 8 months ago (2016-04-07 23:02:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6217e3d464614465e46080937f99e9fbf1dc08df.

Powered by Google App Engine
This is Rietveld 408576698