Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1862923002: Lighten incognito frame when inactive, instead of darkening it. (Closed)

Created:
4 years, 8 months ago by Peter Kasting
Modified:
4 years, 8 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Lighten incognito frame when inactive, instead of darkening it. BUG=599952 TEST=Run Chrome with --top-chrome-md=material on Linux, using the Classic theme. Open an incognito window and then deactivate it. The frame should lighten and the outlines around tabs should stay dark. Committed: https://crrev.com/f549e90f4bf57b261f0f9db9971dc0193b433358 Cr-Commit-Position: refs/heads/master@{#385593}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/themes/theme_properties.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Peter Kasting
4 years, 8 months ago (2016-04-06 01:09:35 UTC) #2
Evan Stade
lgtm
4 years, 8 months ago (2016-04-06 21:11:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862923002/1
4 years, 8 months ago (2016-04-06 21:17:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-07 00:01:41 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 00:03:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f549e90f4bf57b261f0f9db9971dc0193b433358
Cr-Commit-Position: refs/heads/master@{#385593}

Powered by Google App Engine
This is Rietveld 408576698