Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1867053004: Roll HarfBuzz to 1.2.6 (Closed)

Created:
4 years, 8 months ago by drott
Modified:
4 years, 8 months ago
CC:
chromium-reviews, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll HarfBuzz to 1.2.6 Following Behdad's recommendation to pull this version. BUG=601528 R=eae,kojii,behdad

Patch Set 1 #

Patch Set 2 : Roll to 1.2.6 instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+989 lines, -504 lines) Patch
M third_party/harfbuzz-ng/NEWS View 1 1 chunk +86 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/README.chromium View 1 2 chunks +2 lines, -14 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-buffer.cc View 2 chunks +2 lines, -70 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-buffer-private.hh View 4 chunks +47 lines, -18 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-coretext.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-deprecated.h View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-directwrite.cc View 1 23 chunks +302 lines, -159 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-fallback-shape.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-font.h View 5 chunks +43 lines, -12 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-font.cc View 3 chunks +206 lines, -14 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-font-private.hh View 3 chunks +18 lines, -8 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ft.cc View 2 chunks +25 lines, -13 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-icu.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-open-type-private.hh View 1 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-cmap-table.hh View 4 chunks +66 lines, -59 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-font.cc View 6 chunks +76 lines, -27 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-glyf-table.hh View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-hmtx-table.hh View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout.cc View 1 1 chunk +29 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout-gsub-table.hh View 1 chunk +20 lines, -2 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-map.cc View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape.cc View 7 chunks +3 lines, -61 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-default.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-myanmar.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-private.hh View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-thai.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-use.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-fallback.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-normalize.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-private.hh View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-unicode-private.hh View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-version.h View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867053004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867053004/1
4 years, 8 months ago (2016-04-07 18:11:16 UTC) #2
drott
4 years, 8 months ago (2016-04-07 18:12:30 UTC) #3
drott
I am going to be on a plane, so please go ahead and commit this, ...
4 years, 8 months ago (2016-04-07 18:13:35 UTC) #5
behdad
lgtm
4 years, 8 months ago (2016-04-07 18:14:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867053004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867053004/1
4 years, 8 months ago (2016-04-07 18:16:19 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/201518)
4 years, 8 months ago (2016-04-07 21:05:21 UTC) #11
eae
LGTM
4 years, 8 months ago (2016-04-07 21:37:29 UTC) #12
drott
behdad@, the windows quotation marks issue is back in 1.2.5 :-(
4 years, 8 months ago (2016-04-08 00:59:32 UTC) #13
behdad
On 2016/04/08 00:59:32, drott wrote: > behdad@, the windows quotation marks issue is back in ...
4 years, 8 months ago (2016-04-08 01:01:19 UTC) #14
drott
On 2016/04/08 at 01:01:19, behdad wrote: > On 2016/04/08 00:59:32, drott wrote: > > behdad@, ...
4 years, 8 months ago (2016-04-08 01:28:22 UTC) #15
kojii
On 2016/04/08 at 01:28:22, drott wrote: > On 2016/04/08 at 01:01:19, behdad wrote: > > ...
4 years, 8 months ago (2016-04-08 04:25:35 UTC) #16
kojii
1.2.6 is now out thanks to Behdad. I tried to help the roll to 1.2.6 ...
4 years, 8 months ago (2016-04-10 04:32:28 UTC) #17
chromium-reviews
That's correct. Better remove hb-directwrite as we don't use it. On Apr 9, 2016 9:32 ...
4 years, 8 months ago (2016-04-10 04:44:21 UTC) #18
drott
> So, sorry drott, but I need your help to roll. CL updated to roll ...
4 years, 8 months ago (2016-04-11 09:26:07 UTC) #20
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867053004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867053004/20001
4 years, 8 months ago (2016-04-11 09:26:29 UTC) #22
drott
4 years, 8 months ago (2016-04-11 09:43:09 UTC) #23
Message was sent while issue was closed.
Closed in favor of https://codereview.chromium.org/1874153002/

Powered by Google App Engine
This is Rietveld 408576698