Roll HarfBuzz to 1.2.6

Roll HarfBuzz to 1.2.6

Following Behdad's recommendation to pull this version.

BUG=601528
R=eae,kojii,behdad

[drott, 2016-04-07 18:10:41]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-07 18:11:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867053004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867053004/1

[drott, 2016-04-07 18:12:42]

drott@chromium.org changed reviewers:
+ jshin@chromium.org

[drott, 2016-04-07 18:13:35]

I am going to be on a plane, so please go ahead and commit this, if it looks
good to you and CQ passes.

[behdad, 2016-04-07 18:14:33]

lgtm

[drott, 2016-04-07 18:15:23]

The CQ bit was unchecked by drott@chromium.org

[drott, 2016-04-07 18:15:27]

The CQ bit was checked by drott@chromium.org

[commit-bot: I haz the power, 2016-04-07 18:16:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867053004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867053004/1

[commit-bot: I haz the power, 2016-04-07 21:05:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 21:05:21]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[eae, 2016-04-07 21:37:29]

LGTM

[drott, 2016-04-08 00:59:32]

behdad@, the windows quotation marks issue is back in 1.2.5 :-(

[behdad, 2016-04-08 01:01:19]

On 2016/04/08 00:59:32, drott wrote:
> behdad@, the windows quotation marks issue is back in 1.2.5 :-(

Humm..  Really?!  Can you send me your Times New Roman?!

[drott, 2016-04-08 01:28:22]

On 2016/04/08 at 01:01:19, behdad wrote:
> On 2016/04/08 00:59:32, drott wrote:
> > behdad@, the windows quotation marks issue is back in 1.2.5 :-(
> 
> Humm..  Really?!  Can you send me your Times New Roman?!

Unfortunately not, I can't access a Windows machine while traveling, the
connection is too slow from here. 
It's a bot failure, so I am assuming it's a regular Windows 8 "Times New Roman"
file, maybe someone around you has one?

https://storage.googleapis.com/chromium-layout-test-archives/win_chromium_rel...

[kojii, 2016-04-08 04:25:35]

On 2016/04/08 at 01:28:22, drott wrote:
> On 2016/04/08 at 01:01:19, behdad wrote:
> > On 2016/04/08 00:59:32, drott wrote:
> > > behdad@, the windows quotation marks issue is back in 1.2.5 :-(
> > 
> > Humm..  Really?!  Can you send me your Times New Roman?!
> 
> Unfortunately not, I can't access a Windows machine while traveling, the
connection is too slow from here. 
> It's a bot failure, so I am assuming it's a regular Windows 8 "Times New
Roman" file, maybe someone around you has one?
> 
>
https://storage.googleapis.com/chromium-layout-test-archives/win_chromium_rel...

Confirmed the quotation marks issue in my local Win7 with this CL applied.
Sending my Times New Roman to behdad@.

[kojii, 2016-04-10 04:32:28]

1.2.6 is now out thanks to Behdad. I tried to help the roll to 1.2.6 by copying
1.2.6 tag over to this CL with rebase, but that shows 461 lines of diff in
hb-directwrite.cc, which I can't determine whether I did it correctly or not.

So, sorry drott, but I need your help to roll.

[chromium-reviews, 2016-04-10 04:44:21]

That's correct.  Better remove hb-directwrite as we don't use it.
On Apr 9, 2016 9:32 PM, <kojii@chromium.org> wrote:

> 1.2.6 is now out thanks to Behdad. I tried to help the roll to 1.2.6 by
> copying
> 1.2.6 tag over to this CL with rebase, but that shows 461 lines of diff in
> hb-directwrite.cc, which I can't determine whether I did it correctly or
> not.
>
> So, sorry drott, but I need your help to roll.
>
> https://codereview.chromium.org/1867053004/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[drott, 2016-04-11 09:22:50]

Description was changed from

==========
Roll HarfBuzz to 1.2.5

Following Behdad's recommendation to pull this version.

BUG=601528
R=eae,kojii,behdad
==========

to

==========
Roll HarfBuzz to 1.2.6

Following Behdad's recommendation to pull this version.

BUG=601528
R=eae,kojii,behdad
==========

[drott, 2016-04-11 09:26:07]

> So, sorry drott, but I need your help to roll.

CL updated to roll to 1.2.6. I am not sure whether you saw those, there are some
instructions in the README.chromium file. Let's edit those if there were some
open questions.

As to the DirectWrite changes. We don't compile the file and I was arguing that
it's easier to have less manual steps in the roll process, so I'd be in favor of
keeping it as is, but I am fine either way.

[drott, 2016-04-11 09:26:14]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-11 09:26:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867053004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867053004/20001

[drott, 2016-04-11 09:43:09]

Closed in favor of https://codereview.chromium.org/1874153002/