third_party/harfbuzz-ng/src/hb-ot-shape-fallback.cc - Issue 1867053004: Roll HarfBuzz to 1.2.6

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/harfbuzz-ng/src/hb-ot-shape-fallback.cc

Issue 1867053004: Roll HarfBuzz to 1.2.6 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Roll to 1.2.6 instead Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/harfbuzz-ng/src/hb-ot-shape-fallback.cc

diff --git a/third_party/harfbuzz-ng/src/hb-ot-shape-fallback.cc b/third_party/harfbuzz-ng/src/hb-ot-shape-fallback.cc

index c9cf737f48653f24c2e395a75ac3aaf80c2c81bb..ea8312b223b73784aa78f02dca0f06ebf757be06 100644

--- a/third_party/harfbuzz-ng/src/hb-ot-shape-fallback.cc

+++ b/third_party/harfbuzz-ng/src/hb-ot-shape-fallback.cc

@@ -526,7 +526,7 @@ _hb_ot_shape_fallback_spaces (const hb_ot_shape_plan_t *plan,

case t::SPACE_FIGURE:

for (char u = '0'; u <= '9'; u++)

- if (font->get_glyph (u, 0, &glyph))

+ if (font->get_nominal_glyph (u, &glyph))

{

pos[i].x_advance = font->get_glyph_h_advance (glyph);

break;

@@ -534,9 +534,9 @@ _hb_ot_shape_fallback_spaces (const hb_ot_shape_plan_t *plan,

break;

case t::SPACE_PUNCTUATION:

- if (font->get_glyph ('.', 0, &glyph))

+ if (font->get_nominal_glyph ('.', &glyph))

pos[i].x_advance = font->get_glyph_h_advance (glyph);

- else if (font->get_glyph (',', 0, &glyph))

+ else if (font->get_nominal_glyph (',', &glyph))

pos[i].x_advance = font->get_glyph_h_advance (glyph);

break;