Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 1866993002: Subzero: Fix an incorrect StringPool assert. (Closed)

Created:
4 years, 8 months ago by Jim Stichnoth
Modified:
4 years, 8 months ago
Reviewers:
Eric Holk, Karl, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/IceStringPool.h View 1 chunk +1 line, -1 line 3 comments Download

Messages

Total messages: 6 (3 generated)
Jim Stichnoth
https://codereview.chromium.org/1866993002/diff/1/src/IceStringPool.h File src/IceStringPool.h (right): https://codereview.chromium.org/1866993002/diff/1/src/IceStringPool.h#newcode115 src/IceStringPool.h:115: if (ThisHasString && OtherHasString) Here we test for both ...
4 years, 8 months ago (2016-04-07 12:20:50 UTC) #3
John
lgtm
4 years, 8 months ago (2016-04-07 14:03:35 UTC) #4
Jim Stichnoth
4 years, 8 months ago (2016-04-07 14:17:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d12d3aab3742065f0204692997571d34a406be39 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698