Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: src/IceStringPool.h

Issue 1866993002: Subzero: Fix an incorrect StringPool assert. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceStringPool.h
diff --git a/src/IceStringPool.h b/src/IceStringPool.h
index e6b3d1117b10107fd276d048aad71f9580bf7d37..4b5f6dacbb1cdaf049490a2792c4d14caeffe9dd 100644
--- a/src/IceStringPool.h
+++ b/src/IceStringPool.h
@@ -118,7 +118,7 @@ public:
if (!ThisHasString && !OtherHasString)
Jim Stichnoth 2016/04/07 12:20:50 Here we test for both being false.
return ID < Other.ID;
// If exactly one has a string, then that one comes first.
- assert(!OtherHasString);
+ assert(ThisHasString != OtherHasString);
Jim Stichnoth 2016/04/07 12:20:50 This is just meant to validate that one is true an
return ThisHasString;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698