Remove StartupUtils::IsWebviewSigninEnabled.

Remove StartupUtils::IsWebviewSigninEnabled.

TBR=xiyuan@chromium.org
BUG=470893
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/0a0648a595adaffb322a260ad47b9b260f01791c
Cr-Commit-Position: refs/heads/master@{#437642}

[jdufault, 2016-04-07 17:24:52]

Description was changed from

==========
Remove StartupUtils::IsWebviewSigninEnabled.

BUG=470893
==========

to

==========
Remove StartupUtils::IsWebviewSigninEnabled.

BUG=470893
==========

[jdufault, 2016-04-07 17:24:52]

jdufault@chromium.org changed reviewers:
+ achuith@chromium.org, dzhioev@chromium.org

[jdufault, 2016-04-07 17:25:07]

Achuith or Pavel, PTAL. Thanks!

[achuithb, 2016-04-07 18:39:49]

Some additional minor cleanup if you don't mind

https://codereview.chromium.org/1866813002/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/helper.cc (right):

https://codereview.chromium.org/1866813002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/helper.cc:234: // webview instance.
TODO(nkostylev): Investigate if there's a better
Replace nkostylev with dzhioev

https://codereview.chromium.org/1866813002/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/session/user_session_manager.cc (right):

https://codereview.chromium.org/1866813002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/session/user_session_manager.cc:1543:
net::URLRequestContextGetter* auth_request_context = nullptr;
Get rid of auth_request_context

https://codereview.chromium.org/1866813002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/session/user_session_manager.cc:1546: if
(signin_partition)
invert and return nullptr

https://codereview.chromium.org/1866813002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/session/user_session_manager.cc:1547:
auth_request_context = signin_partition->GetURLRequestContext();
return

https://codereview.chromium.org/1866813002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/session/user_session_manager.cc:1752: if
(TokenHandlesEnabled()) {
Invert and return early

[dzhioev (left Google), 2016-04-12 18:29:34]

https://codereview.chromium.org/1866813002/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/oobe_ui.cc (right):

https://codereview.chromium.org/1866813002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/oobe_ui.cc:134:
source->AddResourcePath("gaia_auth_host.js", IDR_GAIA_AUTH_AUTHENTICATOR_JS);
We don't need to define this resource in runtime anymore. We can just include
"authenticator.js" in compile time from "login_common.js" (with <include
src="...">).

[jdufault, 2016-12-06 22:21:38]

Description was changed from

==========
Remove StartupUtils::IsWebviewSigninEnabled.

BUG=470893
==========

to

==========
Remove StartupUtils::IsWebviewSigninEnabled.

BUG=470893
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[jdufault, 2016-12-06 22:21:42]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 22:22:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 00:26:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 00:26:51]

Dry run: This issue passed the CQ dry run.

[jdufault, 2016-12-07 00:27:55]

Took me awhile to get back to this but PTAL again. Thanks!

https://codereview.chromium.org/1866813002/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/helper.cc (right):

https://codereview.chromium.org/1866813002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/helper.cc:234: // webview instance.
TODO(nkostylev): Investigate if there's a better
On 2016/04/07 18:39:48, achuithb wrote:
> Replace nkostylev with dzhioev

Hmm, any idea on a better owner now? I can assign it to myself but I don't
anticipate getting to it anytime soon.

https://codereview.chromium.org/1866813002/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/session/user_session_manager.cc (right):

https://codereview.chromium.org/1866813002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/session/user_session_manager.cc:1543:
net::URLRequestContextGetter* auth_request_context = nullptr;
On 2016/04/07 18:39:48, achuithb wrote:
> Get rid of auth_request_context

Done.

https://codereview.chromium.org/1866813002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/session/user_session_manager.cc:1546: if
(signin_partition)
On 2016/04/07 18:39:48, achuithb wrote:
> invert and return nullptr

Done.

https://codereview.chromium.org/1866813002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/session/user_session_manager.cc:1547:
auth_request_context = signin_partition->GetURLRequestContext();
On 2016/04/07 18:39:48, achuithb wrote:
> return

Done.

https://codereview.chromium.org/1866813002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/session/user_session_manager.cc:1752: if
(TokenHandlesEnabled()) {
On 2016/04/07 18:39:48, achuithb wrote:
> Invert and return early

Done.

https://codereview.chromium.org/1866813002/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/oobe_ui.cc (right):

https://codereview.chromium.org/1866813002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/oobe_ui.cc:134:
source->AddResourcePath("gaia_auth_host.js", IDR_GAIA_AUTH_AUTHENTICATOR_JS);
On 2016/04/12 18:29:34, dzhioev (left Google) wrote:
> We don't need to define this resource in runtime anymore. We can just include
> "authenticator.js" in compile time from "login_common.js" (with <include
> src="...">).

Done.

[achuithb, 2016-12-07 00:37:09]

lgtm

https://codereview.chromium.org/1866813002/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/helper.cc (right):

https://codereview.chromium.org/1866813002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/helper.cc:234: // webview instance.
TODO(nkostylev): Investigate if there's a better
On 2016/12/07 00:27:55, jdufault wrote:
> On 2016/04/07 18:39:48, achuithb wrote:
> > Replace nkostylev with dzhioev
> 
> Hmm, any idea on a better owner now? I can assign it to myself but I don't
> anticipate getting to it anytime soon.

Let's just get rid of the TODO. I don't think anyone is going to fix this.

[jdufault, 2016-12-08 23:58:30]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2016-12-08 23:58:30]

The patchset sent to the CQ was uploaded after l-g-t-m from achuith@chromium.org
Link to the patchset: https://codereview.chromium.org/1866813002/#ps40001
(title: "Remove TODO")

[commit-bot: I haz the power, 2016-12-08 23:58:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 00:08:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 00:08:47]

Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[jdufault, 2016-12-09 18:15:15]

The CQ bit was checked by jdufault@chromium.org

[commit-bot: I haz the power, 2016-12-09 18:15:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 19:04:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 19:04:05]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jdufault, 2016-12-09 20:29:56]

Description was changed from

==========
Remove StartupUtils::IsWebviewSigninEnabled.

BUG=470893
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove StartupUtils::IsWebviewSigninEnabled.

TBR=xiyuan@chromium.org
BUG=470893
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[jdufault, 2016-12-09 20:30:02]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2016-12-09 20:30:26]

On 2016/12/09 19:04:05, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

TBR=xiyuan for trivial change in browser_resources.grd

[commit-bot: I haz the power, 2016-12-09 20:31:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 20:54:06]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481315402274860,
"parent_rev": "d0da6b4a767acd1e6c663d970c1c1edeeb156546", "commit_rev":
"405f9cf62d69f49572d470ab14b5af3c07ced45e"}

[commit-bot: I haz the power, 2016-12-09 20:54:38]

Description was changed from

==========
Remove StartupUtils::IsWebviewSigninEnabled.

TBR=xiyuan@chromium.org
BUG=470893
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove StartupUtils::IsWebviewSigninEnabled.

TBR=xiyuan@chromium.org
BUG=470893
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1866813002
==========

[commit-bot: I haz the power, 2016-12-09 20:54:39]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-12 14:40:26]

Description was changed from

==========
Remove StartupUtils::IsWebviewSigninEnabled.

TBR=xiyuan@chromium.org
BUG=470893
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1866813002
==========

to

==========
Remove StartupUtils::IsWebviewSigninEnabled.

TBR=xiyuan@chromium.org
BUG=470893
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/0a0648a595adaffb322a260ad47b9b260f01791c
Cr-Commit-Position: refs/heads/master@{#437642}
==========

[commit-bot: I haz the power, 2016-12-12 14:40:27]

Patchset 3 (id:??) landed as
https://crrev.com/0a0648a595adaffb322a260ad47b9b260f01791c
Cr-Commit-Position: refs/heads/master@{#437642}