Issue 1866773002: Test CTFonts for equality, not just name and style.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1866773002: Test CTFonts for equality, not just name and style.

Created:
4 years, 8 months ago by bungeman-skia

Modified:
4 years, 8 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Test CTFonts for equality, not just name and style. The current code looks up CTFonts from descriptors by just name and style. This is not sufficient, for example Avenir Book and Avenir Roman have the same family name but the same basic style, but are obviously not the same. COMMIT=false This exists as an early warning for https://codereview.chromium.org/1860993004/ BUG=skia:5162

Patch Set 1 #

Patch Set 2 : Generalize patching procedure. #

Patch Set 3 : Just use rietveld! #

Patch Set 4 : Use apply patch since git cl patch doesn't seem to work. #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -0 lines)			Patch
	M	DEPS	View	1 2 3	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

bungeman-skia

4 years, 8 months ago (2016-04-06 20:15:25 UTC) #1

Reported https://crbug.com/601166 about the lack of test coverage on the trybot
run.

Expand Messages | Collapse Messages