Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(28)

Issue 1866773002: Test CTFonts for equality, not just name and style.

Created:
3 years, 8 months ago by bungeman-skia
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Test CTFonts for equality, not just name and style. The current code looks up CTFonts from descriptors by just name and style. This is not sufficient, for example Avenir Book and Avenir Roman have the same family name but the same basic style, but are obviously not the same. COMMIT=false This exists as an early warning for https://codereview.chromium.org/1860993004/ BUG=skia:5162

Patch Set 1 #

Patch Set 2 : Generalize patching procedure. #

Patch Set 3 : Just use rietveld! #

Patch Set 4 : Use apply patch since git cl patch doesn't seem to work. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M DEPS View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
bungeman-skia
3 years, 8 months ago (2016-04-06 20:15:25 UTC) #1
Reported https://crbug.com/601166 about the lack of test coverage on the trybot
run.

Powered by Google App Engine
This is Rietveld 408576698