Code completion build fix following https://codereview.chromium.org/1860213002, fix test_all.dart t…

Code completion build fix following https://codereview.chromium.org/1860213002, fix test_all.dart to include completion_test.dart

R=danrubel@google.com, paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/04a14d0020ffac780ee30ca23e528a6d2ce5a249

[jwren, 2016-04-06 20:07:57]

jwren@google.com changed reviewers:
+ danrubel@google.com, paulberry@google.com

[danrubel, 2016-04-06 20:16:03]

LGTM

https://codereview.chromium.org/1866753004/diff/1/pkg/analysis_server/test/te...
File pkg/analysis_server/test/test_all.dart (right):

https://codereview.chromium.org/1866753004/diff/1/pkg/analysis_server/test/te...
pkg/analysis_server/test/test_all.dart:39: completion_test.main();
I believe that the bots run this test separately, so I don't think it belongs
here. Ok to leave it here and run the tests twice if Brian et al are ok with
that.

[Paul Berry, 2016-04-06 20:22:35]

lgtm

https://codereview.chromium.org/1866753004/diff/1/pkg/analysis_server/test/te...
File pkg/analysis_server/test/test_all.dart (right):

https://codereview.chromium.org/1866753004/diff/1/pkg/analysis_server/test/te...
pkg/analysis_server/test/test_all.dart:39: completion_test.main();
On 2016/04/06 20:16:03, danrubel wrote:
> I believe that the bots run this test separately, so I don't think it belongs
> here. Ok to leave it here and run the tests twice if Brian et al are ok with
> that.

Actually, this won't cause the bots to run the test twice, because the bots
don't run test_all.dart.  They only run tests ending with "_test.dart".  This
file exists merely for the convenience of analyzer developers, some of whom
prefer to run all the tests in a single invocation (e.g. with an IDE) rather
than via test.sh.

So I think it makes sense to add this line, since it will ensure that when
developers run tests in this way, they don't miss out on failures in
completion_test.

[jwren, 2016-04-06 21:26:21]

Description was changed from

==========
Code completion build fix following https://codereview.chromium.org/1860213002,
fix test_all.dart to include completion_test.dart
==========

to

==========
Code completion build fix following https://codereview.chromium.org/1860213002,
fix test_all.dart to include completion_test.dart

R=danrubel@google.com, paulberry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/04a14d0020ffac780ee30ca23e528a6d2ce5a249
==========

[jwren, 2016-04-06 21:26:23]

Committed patchset #2 (id:20001) manually as
04a14d0020ffac780ee30ca23e528a6d2ce5a249 (presubmit successful).