Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1860213002: Fix for issue 24555: import/export/part completion improvement. (Closed)

Created:
4 years, 8 months ago by jwren
Modified:
4 years, 8 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for issue 24555: import/export/part completion improvement. BUG=https://github.com/dart-lang/sdk/issues/24555 R=danrubel@google.com Committed: https://github.com/dart-lang/sdk/commit/84b9a479268792fa7868d41c79b921f19d8787b0

Patch Set 1 #

Patch Set 2 : Fix tests in domain_completion_test.dart #

Total comments: 2

Patch Set 3 : Comment from DanR #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -19 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/keyword_contributor.dart View 1 chunk +6 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 1 3 chunks +12 lines, -12 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart View 1 2 3 chunks +12 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jwren
4 years, 8 months ago (2016-04-05 22:06:43 UTC) #3
danrubel
LGTM https://codereview.chromium.org/1860213002/diff/20001/pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart File pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart (right): https://codereview.chromium.org/1860213002/diff/20001/pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart#newcode259 pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart:259: expect(s.relevance + 1, equals(importRelevance), Can the "+ 1" ...
4 years, 8 months ago (2016-04-06 01:16:45 UTC) #4
jwren
https://codereview.chromium.org/1860213002/diff/20001/pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart File pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart (right): https://codereview.chromium.org/1860213002/diff/20001/pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart#newcode259 pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart:259: expect(s.relevance + 1, equals(importRelevance), Yes, done.
4 years, 8 months ago (2016-04-06 16:51:20 UTC) #5
jwren
Committed patchset #3 (id:40001) manually as 84b9a479268792fa7868d41c79b921f19d8787b0 (presubmit successful).
4 years, 8 months ago (2016-04-06 16:52:53 UTC) #7
Paul Berry
4 years, 8 months ago (2016-04-06 18:10:19 UTC) #8
Message was sent while issue was closed. 
On 2016/04/06 16:52:53, jwren wrote:
> Committed patchset #3 (id:40001) manually as
> 84b9a479268792fa7868d41c79b921f19d8787b0 (presubmit successful).

It looks like this broke a unit test.

Repro with: python tools/test.py -aia32 --checked -mrelease -t60
pkg/analysis_server/test/completion_test

Would you mind having a look?

Powered by Google App Engine
This is Rietveld 408576698