Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: Source/bindings/templates/interface.cpp

Issue 186673002: Support deprecation + use counters for constructor attributes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Always generate constructor getter callbacks Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/templates/interface.cpp
diff --git a/Source/bindings/templates/interface.cpp b/Source/bindings/templates/interface.cpp
index 0c2bedb14fc9967f5e26b20976f8f30a1b297742..1cc38535cd087a750399863fcf3b73c7543f1a1d 100644
--- a/Source/bindings/templates/interface.cpp
+++ b/Source/bindings/templates/interface.cpp
@@ -7,7 +7,8 @@
'%sV8Internal::%sAttributeGetterCallback' %
(cpp_class, attribute.name)
if not attribute.constructor_type else
- '{0}V8Internal::{0}ConstructorGetter'.format(cpp_class) %}
+ '%sV8Internal::%sConstructorGetterCallback' %
Nils Barth (inactive) 2014/03/05 07:27:52 Minor point: could we give these the same name? I.
sof 2014/03/05 12:45:48 Switched to using "AttributeGetterCallback" as suf
+ (cpp_class, attribute.name) %}
{% set getter_callback_for_main_world =
'%sV8Internal::%sAttributeGetterCallbackForMainWorld' %
(cpp_class, attribute.name)
@@ -74,7 +75,6 @@ static void {{cpp_class}}ConstructorGetter(v8::Local<v8::String>, const v8::Prop
{% endif %}
{% endblock %}
-
Nils Barth (inactive) 2014/03/05 07:27:52 Could you leave this line? The convention I've bee
sof 2014/03/05 12:45:48 Accidental line removal reverted.
{##############################################################################}
{% block replaceable_attribute_setter_and_callback %}
{% if has_replaceable_attributes or has_constructor_attributes %}

Powered by Google App Engine
This is Rietveld 408576698