Support deprecation + use counters for constructor attributes.

Source/bindings/templates/interface.cpp

 {% extends 'interface_base.cpp' %}
 
 
 {##############################################################################}
 {% macro attribute_configuration(attribute) %}
 {% set getter_callback =
        '%sV8Internal::%sAttributeGetterCallback' %
             (cpp_class, attribute.name)
        if not attribute.constructor_type else
-       '{0}V8Internal::{0}ConstructorGetter'.format(cpp_class) %}
+       '%sV8Internal::%sConstructorGetterCallback' %

[Nils Barth (inactive), 2014/03/05 07:27:52]

Minor point:
could we give these the same name?
I.e., in both cases use:
'%sV8Internal::%sAttributeGetterCallback'
?
This shouldn't cause overlap, as we're generating these in mutually exclusive
loops.
Might be simpler/cleaner, or might cause confusion.

[sof, 2014/03/05 12:45:48]

Switched to using "AttributeGetterCallback" as suffix for these also.

+            (cpp_class, attribute.name) %}
 {% set getter_callback_for_main_world =
        '%sV8Internal::%sAttributeGetterCallbackForMainWorld' %
             (cpp_class, attribute.name)
        if attribute.is_per_world_bindings else '0' %}
 {% set setter_callback = attribute.setter_callback %}
 {% set setter_callback_for_main_world =
        '%sV8Internal::%sAttributeSetterCallbackForMainWorld' %
            (cpp_class, attribute.name)
        if attribute.is_per_world_bindings and
           (not attribute.is_read_only or attribute.put_forwards) else '0' %}
@@ skipping 46 matching lines @@
     ASSERT(data->IsExternal());
     V8PerContextData* perContextData = V8PerContextData::from(info.Holder()->CreationContext());
     if (!perContextData)
         return;
     v8SetReturnValue(info, perContextData->constructorForType(WrapperTypeInfo::unwrap(data)));
 }
 
 {% endif %}
 {% endblock %}
 
-

[Nils Barth (inactive), 2014/03/05 07:27:52]

Could you leave this line?
The convention I've been using (and will write up) is:
2 blank lines between blocks/macros,
just as with Python top-level functions.

[sof, 2014/03/05 12:45:48]

Accidental line removal reverted.

 {##############################################################################}
 {% block replaceable_attribute_setter_and_callback %}
 {% if has_replaceable_attributes or has_constructor_attributes %}
 {# FIXME: rename to ForceSetAttributeOnThis, since also used for Constructors #}
 static void {{cpp_class}}ReplaceableAttributeSetter(v8::Local<v8::String> name, v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info)
 {
     {% if is_check_security %}
     {{cpp_class}}* imp = {{v8_class}}::toNative(info.Holder());
     v8::String::Utf8Value attributeName(name);
     ExceptionState exceptionState(ExceptionState::SetterContext, *attributeName, "{{interface_name}}", info.Holder(), info.GetIsolate());
@@ skipping 1229 matching lines @@
 {% endfilter %}
 }
 
 template<>
 v8::Handle<v8::Value> toV8NoInline({{cpp_class}}* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
 {
     return toV8(impl, creationContext, isolate);
 }
 
 {% endblock %}