third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.h - Issue 1866703002: Use characters (not code units) when computing value list positions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.h

Issue 1866703002: Use characters (not code units) when computing value list positions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@svg-metrics-cleanup-14

Patch Set: Simplify the test some more. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/svg/text/surrogate-pair-attribute-positions-expected.html ('k') | third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.h

diff --git a/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.h b/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.h

index 9d2917c594cc6bc180492519c48b464aefa595c7..817a3e056b5622668b3a4e6977dbc369c64d7db7 100644

--- a/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.h

+++ b/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.h

@@ -73,11 +73,11 @@ public:

private:

void buildCharacterDataMap(LayoutSVGText&);

void buildLayoutAttributes(LayoutSVGText&) const;

- void collectTextPositioningElements(LayoutBoxModelObject&, UChar& lastCharacter);

+ void collectTextPositioningElements(LayoutBoxModelObject&);

void fillCharacterDataMap(const TextPosition&);

private:

- unsigned m_textLength;

+ unsigned m_characterCount;

PersistentHeapVector<TextPosition> m_textPositions;

SVGCharacterDataMap m_characterDataMap;

};