Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Side by Side Diff: third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.h

Issue 1866703002: Use characters (not code units) when computing value list positions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@svg-metrics-cleanup-14
Patch Set: Simplify the test some more. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) Research In Motion Limited 2010-2012. All rights reserved. 2 * Copyright (C) Research In Motion Limited 2010-2012. All rights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 DECLARE_TRACE(); 66 DECLARE_TRACE();
67 67
68 Member<SVGTextPositioningElement> element; 68 Member<SVGTextPositioningElement> element;
69 unsigned start; 69 unsigned start;
70 unsigned length; 70 unsigned length;
71 }; 71 };
72 72
73 private: 73 private:
74 void buildCharacterDataMap(LayoutSVGText&); 74 void buildCharacterDataMap(LayoutSVGText&);
75 void buildLayoutAttributes(LayoutSVGText&) const; 75 void buildLayoutAttributes(LayoutSVGText&) const;
76 void collectTextPositioningElements(LayoutBoxModelObject&, UChar& lastCharac ter); 76 void collectTextPositioningElements(LayoutBoxModelObject&);
77 void fillCharacterDataMap(const TextPosition&); 77 void fillCharacterDataMap(const TextPosition&);
78 78
79 private: 79 private:
80 unsigned m_textLength; 80 unsigned m_characterCount;
81 PersistentHeapVector<TextPosition> m_textPositions; 81 PersistentHeapVector<TextPosition> m_textPositions;
82 SVGCharacterDataMap m_characterDataMap; 82 SVGCharacterDataMap m_characterDataMap;
83 }; 83 };
84 84
85 } // namespace blink 85 } // namespace blink
86 86
87 WTF_ALLOW_MOVE_AND_INIT_WITH_MEM_FUNCTIONS(blink::SVGTextLayoutAttributesBuilder ::TextPosition); 87 WTF_ALLOW_MOVE_AND_INIT_WITH_MEM_FUNCTIONS(blink::SVGTextLayoutAttributesBuilder ::TextPosition);
88 88
89 #endif 89 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698