Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 186663009: Mojo: Make mojob.sh die if sync or gyp fails. (Closed)

Created:
6 years, 9 months ago by viettrungluu
Modified:
6 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Make mojob.sh die if sync or gyp fails. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255423

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
mojo/tools/mojob.sh View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
viettrungluu
6 years, 9 months ago (2014-03-06 17:12:36 UTC) #1
viettrungluu
6 years, 9 months ago (2014-03-06 17:12:37 UTC) #2
viettrungluu
6 years, 9 months ago (2014-03-06 17:12:37 UTC) #3
viettrungluu
6 years, 9 months ago (2014-03-06 17:12:38 UTC) #4
sky
LGTM
6 years, 9 months ago (2014-03-06 17:18:15 UTC) #5
viettrungluu
6 years, 9 months ago (2014-03-06 20:52:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r255423 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698