Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Unified Diff: mojo/tools/mojob.sh

Issue 186663009: Mojo: Make mojob.sh die if sync or gyp fails. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/tools/mojob.sh
diff --git a/mojo/tools/mojob.sh b/mojo/tools/mojob.sh
index dc4013acf4fe0054913acdad94172c3b970637e4..81c4466eebb8d73945e8565f68a6c44eaeb3c2ba 100755
--- a/mojo/tools/mojob.sh
+++ b/mojo/tools/mojob.sh
@@ -65,7 +65,12 @@ do_perftests() {
do_gyp() {
local gyp_defines="$(make_gyp_defines)"
echo "Running gyp with GYP_DEFINES=$gyp_defines ..."
- GYP_DEFINES="$gyp_defines" build/gyp_chromium mojo/mojo.gyp
+ GYP_DEFINES="$gyp_defines" build/gyp_chromium mojo/mojo.gyp || exit 1
+}
+
+do_sync() {
+ # Note: sync only (with hooks, but no gyp-ing).
+ GYP_CHROMIUM_NO_ACTION=1 gclient sync || exit 1
}
# Valid values: Debug, Release, or Debug_and_Release.
@@ -135,8 +140,7 @@ for arg in "$@"; do
do_gyp
;;
sync)
- # Note: sync only (with hooks, but no gyp-ing).
- GYP_CHROMIUM_NO_ACTION=1 gclient sync
+ do_sync
;;
show-bash-alias)
# You want to type something like:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698