Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1866613003: [turbofan] Deprecate CompilationInfo::has_literal predicate. (Closed)

Created:
4 years, 8 months ago by Michael Starzinger
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer, titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Deprecate CompilationInfo::has_literal predicate. Now that the SharedFunctionInfo is available to compilers all of the time, we no longer need to rely on the literal for source printing. R=titzer@chromium.org Committed: https://crrev.com/51d3932580a2fa45ad0c2b4aa1e5831939a87250 Cr-Commit-Position: refs/heads/master@{#35326}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -18 lines) Patch
M src/compiler.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/linkage.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
Michael Starzinger
4 years, 8 months ago (2016-04-06 12:25:57 UTC) #2
Benedikt Meurer
LGTM.
4 years, 8 months ago (2016-04-07 08:38:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866613003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866613003/1
4 years, 8 months ago (2016-04-07 08:40:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-07 08:43:13 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 08:44:58 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51d3932580a2fa45ad0c2b4aa1e5831939a87250
Cr-Commit-Position: refs/heads/master@{#35326}

Powered by Google App Engine
This is Rietveld 408576698