[parser] Remove ParseInfo::closure field.

[parser] Remove ParseInfo::closure field.

The parser should never need to look at the underlying closure object,
hence the field can be moved from ParseInfo into CompilationInfo.

R=rossberg@chromium.org

Committed: https://crrev.com/1407c89427174222847e9d666fb9785cf8967030
Cr-Commit-Position: refs/heads/master@{#35358}

[rossberg, 2016-04-06 14:57:32]

LGTM with one optional suggestion

https://codereview.chromium.org/1863083002/diff/20001/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/1863083002/diff/20001/src/compiler.cc#newcode...
src/compiler.cc:1158: CompilationInfo info(&parse_info,
Handle<JSFunction>::null());
Given the frequency of this case, why not make null a default argument?

[Michael Starzinger, 2016-04-06 16:14:00]

https://codereview.chromium.org/1863083002/diff/20001/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/1863083002/diff/20001/src/compiler.cc#newcode...
src/compiler.cc:1158: CompilationInfo info(&parse_info,
Handle<JSFunction>::null());
On 2016/04/06 14:57:32, rossberg wrote:
> Given the frequency of this case, why not make null a default argument?

The frequency of this case is _only_ in compiler.cc, never outside. I intend to
drastically reduce that frequency inside and therefore didn't bother with the
default parameter. It also invites abuse from outside, which I wanted to avoid.

But I would be fine either way and will happily add a default argument. Please
advise on whether you want me to add a null default argument.

[rossberg, 2016-04-06 16:29:58]

On 2016/04/06 16:14:00, Michael Starzinger wrote:
> https://codereview.chromium.org/1863083002/diff/20001/src/compiler.cc
> File src/compiler.cc (right):
> 
>
https://codereview.chromium.org/1863083002/diff/20001/src/compiler.cc#newcode...
> src/compiler.cc:1158: CompilationInfo info(&parse_info,
> Handle<JSFunction>::null());
> On 2016/04/06 14:57:32, rossberg wrote:
> > Given the frequency of this case, why not make null a default argument?
> 
> The frequency of this case is _only_ in compiler.cc, never outside. I intend
to
> drastically reduce that frequency inside and therefore didn't bother with the
> default parameter. It also invites abuse from outside, which I wanted to
avoid.
> 
> But I would be fine either way and will happily add a default argument. Please
> advise on whether you want me to add a null default argument.

Fair enough. That's a good reason to ignore the suggestion.

[Jakob Kummerow, 2016-04-08 12:14:39]

jkummerow@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Jakob Kummerow, 2016-04-08 12:14:40]

src/crankshaft/ LGTM.

[Michael Starzinger, 2016-04-08 12:14:45]

+Jakob: Needs Crankshaft owner stamp.

[Michael Starzinger, 2016-04-08 12:15:54]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2016-04-08 12:15:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
rossberg@chromium.org
Link to the patchset: https://codereview.chromium.org/1863083002/#ps40001
(title: "Rebased.")

[commit-bot: I haz the power, 2016-04-08 12:16:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1863083002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1863083002/40001

[commit-bot: I haz the power, 2016-04-08 12:31:47]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-08 12:32:32]

Description was changed from

==========
[parser] Remove ParseInfo::closure field.

The parser should never need to look at the underlying closure object,
hence the field can be moved from ParseInfo into CompilationInfo.

R=rossberg@chromium.org
==========

to

==========
[parser] Remove ParseInfo::closure field.

The parser should never need to look at the underlying closure object,
hence the field can be moved from ParseInfo into CompilationInfo.

R=rossberg@chromium.org

Committed: https://crrev.com/1407c89427174222847e9d666fb9785cf8967030
Cr-Commit-Position: refs/heads/master@{#35358}
==========

[commit-bot: I haz the power, 2016-04-08 12:32:33]

Patchset 3 (id:??) landed as
https://crrev.com/1407c89427174222847e9d666fb9785cf8967030
Cr-Commit-Position: refs/heads/master@{#35358}