Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 18666006: Refactor compute minus zero checks into a proper HPhase. (Closed)

Created:
7 years, 5 months ago by Benedikt Meurer
Modified:
7 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Refactor compute minus zero checks into a proper HPhase. R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15595

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -68 lines) Patch
M src/hydrogen.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/hydrogen.cc View 4 chunks +2 lines, -66 lines 0 comments Download
A src/hydrogen-minus-zero.h View 1 chunk +56 lines, -0 lines 0 comments Download
A src/hydrogen-minus-zero.cc View 1 chunk +83 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
7 years, 5 months ago (2013-07-10 14:03:51 UTC) #1
Dmitry Lomov (no reviews)
lgtm
7 years, 5 months ago (2013-07-10 14:06:55 UTC) #2
Benedikt Meurer
7 years, 5 months ago (2013-07-10 14:08:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15595 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698