Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1018)

Side by Side Diff: src/hydrogen.h

Issue 18666006: Refactor compute minus zero checks into a proper HPhase. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 276 matching lines...) Expand 10 before | Expand all | Expand 10 after
287 287
288 const ZoneList<HBasicBlock*>* blocks() const { return &blocks_; } 288 const ZoneList<HBasicBlock*>* blocks() const { return &blocks_; }
289 const ZoneList<HPhi*>* phi_list() const { return phi_list_; } 289 const ZoneList<HPhi*>* phi_list() const { return phi_list_; }
290 HBasicBlock* entry_block() const { return entry_block_; } 290 HBasicBlock* entry_block() const { return entry_block_; }
291 HEnvironment* start_environment() const { return start_environment_; } 291 HEnvironment* start_environment() const { return start_environment_; }
292 292
293 void FinalizeUniqueValueIds(); 293 void FinalizeUniqueValueIds();
294 void InsertTypeConversions(); 294 void InsertTypeConversions();
295 void MergeRemovableSimulates(); 295 void MergeRemovableSimulates();
296 void MarkDeoptimizeOnUndefined(); 296 void MarkDeoptimizeOnUndefined();
297 void ComputeMinusZeroChecks();
298 bool ProcessArgumentsObject(); 297 bool ProcessArgumentsObject();
299 void Canonicalize(); 298 void Canonicalize();
300 void OrderBlocks(); 299 void OrderBlocks();
301 void AssignDominators(); 300 void AssignDominators();
302 void SetupInformativeDefinitions(); 301 void SetupInformativeDefinitions();
303 void DehoistSimpleArrayIndexComputations(); 302 void DehoistSimpleArrayIndexComputations();
304 void RestoreActualValues(); 303 void RestoreActualValues();
305 void PropagateDeoptimizingMark(); 304 void PropagateDeoptimizingMark();
306 void AnalyzeAndPruneEnvironmentLiveness(); 305 void AnalyzeAndPruneEnvironmentLiveness();
307 306
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
442 441
443 template<class Phase> 442 template<class Phase>
444 void Run() { 443 void Run() {
445 Phase phase(this); 444 Phase phase(this);
446 phase.Run(); 445 phase.Run();
447 } 446 }
448 447
449 void MarkAsDeoptimizingRecursively(HBasicBlock* block); 448 void MarkAsDeoptimizingRecursively(HBasicBlock* block);
450 void NullifyUnreachableInstructions(); 449 void NullifyUnreachableInstructions();
451 void InsertTypeConversions(HInstruction* instr); 450 void InsertTypeConversions(HInstruction* instr);
452 void PropagateMinusZeroChecks(HValue* value, BitVector* visited);
453 void RecursivelyMarkPhiDeoptimizeOnUndefined(HPhi* phi); 451 void RecursivelyMarkPhiDeoptimizeOnUndefined(HPhi* phi);
454 void CheckForBackEdge(HBasicBlock* block, HBasicBlock* successor); 452 void CheckForBackEdge(HBasicBlock* block, HBasicBlock* successor);
455 void SetupInformativeDefinitionsInBlock(HBasicBlock* block); 453 void SetupInformativeDefinitionsInBlock(HBasicBlock* block);
456 void SetupInformativeDefinitionsRecursively(HBasicBlock* block); 454 void SetupInformativeDefinitionsRecursively(HBasicBlock* block);
457 455
458 Isolate* isolate_; 456 Isolate* isolate_;
459 int next_block_id_; 457 int next_block_id_;
460 HBasicBlock* entry_block_; 458 HBasicBlock* entry_block_;
461 HEnvironment* start_environment_; 459 HEnvironment* start_environment_;
462 ZoneList<HBasicBlock*> blocks_; 460 ZoneList<HBasicBlock*> blocks_;
(...skipping 1637 matching lines...) Expand 10 before | Expand all | Expand 10 after
2100 EmbeddedVector<char, 64> filename_; 2098 EmbeddedVector<char, 64> filename_;
2101 HeapStringAllocator string_allocator_; 2099 HeapStringAllocator string_allocator_;
2102 StringStream trace_; 2100 StringStream trace_;
2103 int indent_; 2101 int indent_;
2104 }; 2102 };
2105 2103
2106 2104
2107 } } // namespace v8::internal 2105 } } // namespace v8::internal
2108 2106
2109 #endif // V8_HYDROGEN_H_ 2107 #endif // V8_HYDROGEN_H_
OLDNEW
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698