Source/bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp - Issue 186633002: Change RefPtr<DOMWrapperWorld> that causes reference cycles to DOMWrapperWorld*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp

Issue 186633002: Change RefPtr<DOMWrapperWorld> that causes reference cycles to DOMWrapperWorld* Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp

diff --git a/Source/bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp b/Source/bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp

index fc597c110345da297a77e706a57a2381e2f72629..aa072ea03ee1a9c1a77b769b308ccb51d82d94e1 100644

--- a/Source/bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp

+++ b/Source/bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp

@@ -47,7 +47,7 @@ bool V8SQLStatementErrorCallback::handleEvent(SQLTransaction* transaction, SQLEr

v8::Isolate* isolate = v8::Isolate::GetCurrent();

v8::HandleScope handleScope(isolate);

- v8::Handle<v8::Context> v8Context = toV8Context(executionContext(), m_world.get());

+ v8::Handle<v8::Context> v8Context = toV8Context(executionContext(), m_world);

if (v8Context.IsEmpty())

return true;

« no previous file with comments | « Source/bindings/v8/WorkerScriptController.cpp ('k') | Source/core/events/ErrorEvent.h » ('j') | no next file with comments »