Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Unified Diff: Source/core/events/ErrorEvent.h

Issue 186633002: Change RefPtr<DOMWrapperWorld> that causes reference cycles to DOMWrapperWorld* Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp ('k') | Source/core/events/ErrorEvent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/events/ErrorEvent.h
diff --git a/Source/core/events/ErrorEvent.h b/Source/core/events/ErrorEvent.h
index cd1be4d864df7952b900225550fe075f60630848..e4072c7ae20e3aa9a40e6200911eb9fb55ae976c 100644
--- a/Source/core/events/ErrorEvent.h
+++ b/Source/core/events/ErrorEvent.h
@@ -53,7 +53,7 @@ public:
{
return adoptRef(new ErrorEvent);
}
- static PassRefPtr<ErrorEvent> create(const String& message, const String& fileName, unsigned lineNumber, unsigned columnNumber, PassRefPtr<DOMWrapperWorld> world)
+ static PassRefPtr<ErrorEvent> create(const String& message, const String& fileName, unsigned lineNumber, unsigned columnNumber, DOMWrapperWorld* world)
{
return adoptRef(new ErrorEvent(message, fileName, lineNumber, columnNumber, world));
}
@@ -61,7 +61,7 @@ public:
{
return adoptRef(new ErrorEvent(type, initializer));
}
- static PassRefPtr<ErrorEvent> createSanitizedError(PassRefPtr<DOMWrapperWorld> world)
+ static PassRefPtr<ErrorEvent> createSanitizedError(DOMWrapperWorld* world)
{
return adoptRef(new ErrorEvent("Script error.", String(), 0, 0, world));
}
@@ -78,7 +78,7 @@ public:
virtual const AtomicString& interfaceName() const OVERRIDE;
- PassRefPtr<DOMWrapperWorld> world() const { return m_world; }
+ DOMWrapperWorld* world() const { return m_world; }
void setUnsanitizedMessage(const String&);
@@ -86,7 +86,7 @@ public:
private:
ErrorEvent();
- ErrorEvent(const String& message, const String& fileName, unsigned lineNumber, unsigned columnNumber, PassRefPtr<DOMWrapperWorld>);
+ ErrorEvent(const String& message, const String& fileName, unsigned lineNumber, unsigned columnNumber, DOMWrapperWorld*);
ErrorEvent(const AtomicString&, const ErrorEventInit&);
String m_unsanitizedMessage;
@@ -95,7 +95,7 @@ private:
unsigned m_lineNumber;
unsigned m_columnNumber;
- RefPtr<DOMWrapperWorld> m_world;
+ DOMWrapperWorld* m_world;
};
} // namespace WebCore
« no previous file with comments | « Source/bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp ('k') | Source/core/events/ErrorEvent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698