Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: Source/bindings/v8/V8AbstractEventListener.cpp

Issue 186633002: Change RefPtr<DOMWrapperWorld> that causes reference cycles to DOMWrapperWorld* Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/V8AbstractEventListener.cpp
diff --git a/Source/bindings/v8/V8AbstractEventListener.cpp b/Source/bindings/v8/V8AbstractEventListener.cpp
index 93134d5f8ae0f0588fc5dfe595f204900e5bf0f2..6216e2554e7ebbfb132a65bf45af922920852210 100644
--- a/Source/bindings/v8/V8AbstractEventListener.cpp
+++ b/Source/bindings/v8/V8AbstractEventListener.cpp
@@ -43,7 +43,7 @@
namespace WebCore {
-V8AbstractEventListener::V8AbstractEventListener(bool isAttribute, PassRefPtr<DOMWrapperWorld> world, v8::Isolate* isolate)
+V8AbstractEventListener::V8AbstractEventListener(bool isAttribute, DOMWrapperWorld* world, v8::Isolate* isolate)
: EventListener(JSEventListenerType)
, m_isAttribute(isAttribute)
, m_world(world)
@@ -77,7 +77,7 @@ void V8AbstractEventListener::handleEvent(ExecutionContext* context, Event* even
v8::HandleScope handleScope(m_isolate);
- v8::Local<v8::Context> v8Context = toV8Context(context, world());
+ v8::Local<v8::Context> v8Context = toV8Context(context, m_world);
if (v8Context.IsEmpty())
return;
@@ -104,7 +104,7 @@ void V8AbstractEventListener::invokeEventHandler(ExecutionContext* context, Even
if (jsEvent.IsEmpty())
return;
- v8::Local<v8::Context> v8Context = toV8Context(context, world());
+ v8::Local<v8::Context> v8Context = toV8Context(context, m_world);
if (v8Context.IsEmpty())
return;
@@ -167,7 +167,7 @@ bool V8AbstractEventListener::shouldPreventDefault(v8::Local<v8::Value> returnVa
v8::Local<v8::Object> V8AbstractEventListener::getReceiverObject(ExecutionContext* context, Event* event)
{
- v8::Isolate* isolate = toV8Context(context, world())->GetIsolate();
+ v8::Isolate* isolate = toV8Context(context, m_world)->GetIsolate();
v8::Local<v8::Object> listener = m_listener.newLocal(isolate);
if (!m_listener.isEmpty() && !listener->IsFunction())
return listener;
« no previous file with comments | « Source/bindings/v8/V8AbstractEventListener.h ('k') | Source/bindings/v8/V8CustomElementLifecycleCallbacks.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698