Source/bindings/v8/V8CustomElementLifecycleCallbacks.h - Issue 186633002: Change RefPtr<DOMWrapperWorld> that causes reference cycles to DOMWrapperWorld*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8CustomElementLifecycleCallbacks.h

Issue 186633002: Change RefPtr<DOMWrapperWorld> that causes reference cycles to DOMWrapperWorld* Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/V8CustomElementLifecycleCallbacks.h

diff --git a/Source/bindings/v8/V8CustomElementLifecycleCallbacks.h b/Source/bindings/v8/V8CustomElementLifecycleCallbacks.h

index f3b062e8b6b2d448f844221fa5dfcaece3779d66..297fd4909b820a1847c528855b3cf4fb9705f8a7 100644

--- a/Source/bindings/v8/V8CustomElementLifecycleCallbacks.h

+++ b/Source/bindings/v8/V8CustomElementLifecycleCallbacks.h

@@ -68,7 +68,7 @@ private:

v8::Isolate* m_isolate;

CustomElementDefinition* m_owner;

- RefPtr<DOMWrapperWorld> m_world;

+ DOMWrapperWorld* m_world;

ScopedPersistent<v8::Object> m_prototype;

ScopedPersistent<v8::Function> m_created;

ScopedPersistent<v8::Function> m_attached;