third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp - Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp

Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp ('k') | third_party/WebKit/Source/modules/installedapp/InstalledAppController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp

diff --git a/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp b/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp

index 96126071cddbdf09b80ddec0f40e2ba0ec2e5957..98dc149bacb0fa1a387e88926365ced9303c5511 100644

--- a/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp

+++ b/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp

@@ -75,12 +75,12 @@ public:

explicit RequestCallbacks(ScriptPromiseResolver* resolver) : m_resolver(resolver) { }

~RequestCallbacks() override { }

- void onSuccess(WebPassOwnPtr<WebCredential> webCredential) override

+ void onSuccess(std::unique_ptr<WebCredential> webCredential) override

{

Frame* frame = toDocument(m_resolver->getScriptState()->getExecutionContext())->frame();

SECURITY_CHECK(!frame || frame == frame->tree().top());

- OwnPtr<WebCredential> credential = webCredential.release();

+ OwnPtr<WebCredential> credential = adoptPtr(webCredential.release());

if (!credential || !frame) {

m_resolver->resolve();

return;