Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp

Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp
diff --git a/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp b/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp
index 8fd87e2d7bc75a638b629a946497b1753f03f7ad..547ad6bf82bc15b80b262ebd1e720b382638fcd2 100644
--- a/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp
+++ b/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp
@@ -3,7 +3,6 @@
// found in the LICENSE file.
#include "modules/cachestorage/InspectorCacheStorageAgent.h"
-
#include "platform/heap/Handle.h"
#include "platform/inspector_protocol/Dispatcher.h"
#include "platform/inspector_protocol/TypeBuilder.h"
@@ -11,7 +10,6 @@
#include "platform/weborigin/KURL.h"
#include "platform/weborigin/SecurityOrigin.h"
#include "public/platform/Platform.h"
-#include "public/platform/WebPassOwnPtr.h"
#include "public/platform/WebSecurityOrigin.h"
#include "public/platform/WebString.h"
#include "public/platform/WebURL.h"
@@ -30,6 +28,7 @@
#include "wtf/text/StringBuilder.h"
#include <algorithm>
+#include <memory>
using blink::protocol::Array;
using blink::protocol::CacheStorage::Cache;
@@ -299,9 +298,9 @@ public:
}
~GetCacheForRequestData() override { }
- void onSuccess(WebPassOwnPtr<WebServiceWorkerCache> cache) override
+ void onSuccess(std::unique_ptr<WebServiceWorkerCache> cache) override
{
- auto* cacheRequest = new GetCacheKeysForRequestData(m_params, cache.release(), m_callback.release());
+ auto* cacheRequest = new GetCacheKeysForRequestData(m_params, adoptPtr(cache.release()), m_callback.release());
cacheRequest->cache()->dispatchKeys(cacheRequest, nullptr, WebServiceWorkerCache::QueryParams());
}
@@ -376,7 +375,7 @@ public:
}
~GetCacheForDeleteEntry() override { }
- void onSuccess(WebPassOwnPtr<WebServiceWorkerCache> cache) override
+ void onSuccess(std::unique_ptr<WebServiceWorkerCache> cache) override
{
auto* deleteRequest = new DeleteCacheEntry(m_callback.release());
BatchOperation deleteOperation;

Powered by Google App Engine
This is Rietveld 408576698