Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp

Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp
diff --git a/third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp b/third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp
index 9e2af89a3640bab5b8cd852574dec70695d51237..9b6e3e7cb993da72fe7a40c85c109755dcd9c5ed 100644
--- a/third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp
+++ b/third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp
@@ -24,13 +24,13 @@ SyncRegistrationCallbacks::~SyncRegistrationCallbacks()
{
}
-void SyncRegistrationCallbacks::onSuccess(WebPassOwnPtr<WebSyncRegistration> webSyncRegistration)
+void SyncRegistrationCallbacks::onSuccess(std::unique_ptr<WebSyncRegistration> webSyncRegistration)
{
if (!m_resolver->getExecutionContext() || m_resolver->getExecutionContext()->activeDOMObjectsAreStopped()) {
return;
}
- OwnPtr<WebSyncRegistration> registration = webSyncRegistration.release();
+ OwnPtr<WebSyncRegistration> registration = adoptPtr(webSyncRegistration.release());
dcheng 2016/04/07 00:26:12 FWIW, I think we'd be saving ourself trouble down
if (!registration) {
m_resolver->resolve(v8::Null(m_resolver->getScriptState()->isolate()));
return;

Powered by Google App Engine
This is Rietveld 408576698